Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoader.h

Issue 2436623004: [Fetch, Loader] Expect on-heap objects will never get destroyed with a reference (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/ThreadableLoader.h
diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoader.h b/third_party/WebKit/Source/core/loader/ThreadableLoader.h
index ef75a632ee68fcd34283f3f48b3770120b0dfd47..d2e1a91abd731c0d9f29a9345c057a045abbb1b0 100644
--- a/third_party/WebKit/Source/core/loader/ThreadableLoader.h
+++ b/third_party/WebKit/Source/core/loader/ThreadableLoader.h
@@ -131,8 +131,6 @@ class CORE_EXPORT ThreadableLoader
WTF_MAKE_NONCOPYABLE(ThreadableLoader);
public:
- // ThreadableLoaderClient methods may not destroy the ThreadableLoader
- // instance in them.
static void loadResourceSynchronously(ExecutionContext&,
const ResourceRequest&,
ThreadableLoaderClient&,
@@ -168,11 +166,6 @@ class CORE_EXPORT ThreadableLoader
// or didFail.*() methods have not been called yet. (didFail() may be
// called with a ResourceError with isCancellation() returning true
// also for cancellation happened inside the loader.)
- //
- // ThreadableLoaderClient methods:
hiroshige 2016/10/21 05:45:14 Isn't the part of "ThreadableLoaderClient methods
yhirano 2016/10/26 11:09:34 You're right, thanks.
- // - may call cancel()
- // - can destroy the ThreadableLoader instance in them (by clearing
- // std::unique_ptr<ThreadableLoader>).
static ThreadableLoader* create(ExecutionContext&,
ThreadableLoaderClient*,
const ThreadableLoaderOptions&,

Powered by Google App Engine
This is Rietveld 408576698