Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 24366004: Split HCompareGeneric in a test and a branch part. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4673 matching lines...) Expand 10 before | Expand all | Expand 10 after
4684 Split(cc, if_true, if_false, NULL); 4684 Split(cc, if_true, if_false, NULL);
4685 __ bind(&slow_case); 4685 __ bind(&slow_case);
4686 } 4686 }
4687 4687
4688 // Record position and call the compare IC. 4688 // Record position and call the compare IC.
4689 SetSourcePosition(expr->position()); 4689 SetSourcePosition(expr->position());
4690 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op); 4690 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op);
4691 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId()); 4691 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId());
4692 patch_site.EmitPatchInfo(); 4692 patch_site.EmitPatchInfo();
4693 4693
4694 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4694 if (!context()->IsEffect()) PrepareForBailout(expr, TOS_REG);
4695 __ testq(rax, rax); 4695 __ testq(rax, rax);
4696 Split(cc, if_true, if_false, fall_through); 4696 Split(cc, if_true, if_false, fall_through);
4697 } 4697 }
4698 } 4698 }
4699 4699
4700 // Convert the result of the comparison into one expected for this 4700 // Convert the result of the comparison into one expected for this
4701 // expression's context. 4701 // expression's context.
4702 context()->Plug(if_true, if_false); 4702 context()->Plug(if_true, if_false);
4703 } 4703 }
4704 4704
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
4955 ASSERT_EQ(kJnsOffset, *(call_target_address - 2)); 4955 ASSERT_EQ(kJnsOffset, *(call_target_address - 2));
4956 return INTERRUPT; 4956 return INTERRUPT;
4957 } 4957 }
4958 } 4958 }
4959 #endif // DEBUG 4959 #endif // DEBUG
4960 4960
4961 4961
4962 } } // namespace v8::internal 4962 } } // namespace v8::internal
4963 4963
4964 #endif // V8_TARGET_ARCH_X64 4964 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698