Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 24366004: Split HCompareGeneric in a test and a branch part. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-arm.h » ('j') | src/hydrogen.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4684 matching lines...) Expand 10 before | Expand all | Expand 10 after
4695 __ cmp(r1, r0); 4695 __ cmp(r1, r0);
4696 Split(cond, if_true, if_false, NULL); 4696 Split(cond, if_true, if_false, NULL);
4697 __ bind(&slow_case); 4697 __ bind(&slow_case);
4698 } 4698 }
4699 4699
4700 // Record position and call the compare IC. 4700 // Record position and call the compare IC.
4701 SetSourcePosition(expr->position()); 4701 SetSourcePosition(expr->position());
4702 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op); 4702 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op);
4703 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId()); 4703 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId());
4704 patch_site.EmitPatchInfo(); 4704 patch_site.EmitPatchInfo();
4705 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4705
4706 if (!context()->IsEffect()) PrepareForBailout(expr, TOS_REG);
4706 __ cmp(r0, Operand::Zero()); 4707 __ cmp(r0, Operand::Zero());
4707 Split(cond, if_true, if_false, fall_through); 4708 Split(cond, if_true, if_false, fall_through);
4708 } 4709 }
4709 } 4710 }
4710 4711
4711 // Convert the result of the comparison into one expected for this 4712 // Convert the result of the comparison into one expected for this
4712 // expression's context. 4713 // expression's context.
4713 context()->Plug(if_true, if_false); 4714 context()->Plug(if_true, if_false);
4714 } 4715 }
4715 4716
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
4981 Memory::uint32_at(interrupt_address_pointer)); 4982 Memory::uint32_at(interrupt_address_pointer));
4982 return INTERRUPT; 4983 return INTERRUPT;
4983 } 4984 }
4984 } 4985 }
4985 #endif // DEBUG 4986 #endif // DEBUG
4986 4987
4987 4988
4988 } } // namespace v8::internal 4989 } } // namespace v8::internal
4989 4990
4990 #endif // V8_TARGET_ARCH_ARM 4991 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-arm.h » ('j') | src/hydrogen.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698