Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2436563002: Select option background added to fix Dark theme (Closed)

Created:
4 years, 2 months ago by anth12
Modified:
4 years, 2 months ago
Reviewers:
chenwilliam, einbinder, chenwilliam, pfeldman
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Global Html Select>Option background styling added to fix Dark theme. BUG=638202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M front_end/settings/settingsScreen.css View 1 chunk +0 lines, -5 lines 0 comments Download
M front_end/ui/inspectorCommon.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
anth12
PTAL
4 years, 2 months ago (2016-10-19 06:47:09 UTC) #3
chenwilliam
Thanks for the patch anth12. It looks like you're a first-time author. Please include yourself ...
4 years, 2 months ago (2016-10-19 22:08:02 UTC) #5
anth12
On 2016/10/19 at 22:08:02, chenwilliam wrote: > Thanks for the patch anth12. It looks like ...
4 years, 2 months ago (2016-10-20 07:42:23 UTC) #6
chenwilliam
4 years, 2 months ago (2016-10-20 20:10:35 UTC) #7
On 2016/10/20 07:42:23, anth12 wrote:
> On 2016/10/19 at 22:08:02, chenwilliam wrote:
> > Thanks for the patch anth12. It looks like you're a first-time author.
Please
> include yourself in the AUTHORS file [0] so we can give you the appropriate
> credit.
> > 
> > [0] https://chromium.googlesource.com/chromium/src/+/master/AUTHORS
> 
> Thank you for the reminder. New patch added
> https://codereview.chromium.org/2434553004
> 
> (Apologies if there was a way of modifying my existing patch)

Thanks! I'll go ahead and close this issue.

Powered by Google App Engine
This is Rietveld 408576698