Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analysis_server/test/domain_server_test.dart

Issue 243653003: Fix and re-enable analysis server tests that were commented out. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_server_test.dart
diff --git a/pkg/analysis_server/test/domain_server_test.dart b/pkg/analysis_server/test/domain_server_test.dart
index 84e290c4784aff99dc625dc3e4ca3cf43a8ced8b..388960618645f93dcc52ad37bb0a10e8e311401f 100644
--- a/pkg/analysis_server/test/domain_server_test.dart
+++ b/pkg/analysis_server/test/domain_server_test.dart
@@ -13,10 +13,10 @@ import 'mocks.dart';
main() {
group('ServerDomainHandler', () {
-// test('createContext', ServerDomainHandlerTest.createContext);
-// test('deleteContext_alreadyDeleted', ServerDomainHandlerTest.deleteContext_alreadyDeleted);
+ test('createContext', ServerDomainHandlerTest.createContext);
+ test('deleteContext_alreadyDeleted', ServerDomainHandlerTest.deleteContext_alreadyDeleted);
test('deleteContext_doesNotExist', ServerDomainHandlerTest.deleteContext_doesNotExist);
-// test('deleteContext_existing', ServerDomainHandlerTest.deleteContext_existing);
+ test('deleteContext_existing', ServerDomainHandlerTest.deleteContext_existing);
test('shutdown', ServerDomainHandlerTest.shutdown);
test('version', ServerDomainHandlerTest.version);
});
@@ -39,7 +39,7 @@ class ServerDomainHandlerTest {
ServerDomainHandler handler = new ServerDomainHandler(server);
Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_METHOD);
- createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, '');
+ createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath);
Response response = handler.handleRequest(createRequest);
String contextId = response.getResult(ServerDomainHandler.CONTEXT_ID_RESULT);
@@ -47,10 +47,8 @@ class ServerDomainHandlerTest {
deleteRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, contextId);
response = handler.handleRequest(deleteRequest);
response = handler.handleRequest(deleteRequest);
- expect(response.toJson(), equals({
- Response.ID: '0',
- Response.ERROR: 'Context does not exist'
- }));
+ expect(response.id, equals('0'));
+ expect(response.error, isNotNull);
}
static void deleteContext_doesNotExist() {
@@ -69,7 +67,7 @@ class ServerDomainHandlerTest {
ServerDomainHandler handler = new ServerDomainHandler(server);
Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_METHOD);
- createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, '');
+ createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath);
Response response = handler.createContext(createRequest);
String contextId = response.getResult(ServerDomainHandler.CONTEXT_ID_RESULT);
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698