Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 24365012: Revert 225054 "linux_aura: Implement most of DesktopScreenX11." (Closed)

Created:
7 years, 3 months ago by Elliot Glaysher
Modified:
7 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 225054 "linux_aura: Implement most of DesktopScreenX11." Compiled on linux_chromeos, but doesn't compile in cros. > linux_aura: Implement most of DesktopScreenX11. > > The linux_aura port didn't deal with multiple monitors very well because > it was treating the X root window as one big display. When xrandr is > present, get the screen areas from it, and exposes this data back to > chrome. > > This patch also factors out the EDID parser than chromeos was using into > a common directory. Like chromeos, we use it to assign stable display > IDs. > > BUG=287972 > R=brettw@chromium.org, derat@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/23536057 TBR=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -993 lines) Patch
M trunk/src/base/base.gyp View 2 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/base/base.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
D trunk/src/base/x11/edid_parser_x11.h View 1 chunk +0 lines, -54 lines 0 comments Download
D trunk/src/base/x11/edid_parser_x11.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D trunk/src/base/x11/edid_parser_x11_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
M trunk/src/build/linux/system.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
M trunk/src/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M trunk/src/chromeos/display/output_util.h View 2 chunks +22 lines, -0 lines 0 comments Download
M trunk/src/chromeos/display/output_util.cc View 4 chunks +186 lines, -5 lines 0 comments Download
M trunk/src/chromeos/display/output_util_unittest.cc View 2 chunks +107 lines, -1 line 0 comments Download
M trunk/src/chromeos/display/real_output_configurator_delegate.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ui/views/views.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D trunk/src/ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 chunk +0 lines, -95 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_screen_x11.cc View 2 chunks +53 lines, -232 lines 0 comments Download
D trunk/src/ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 1 chunk +0 lines, -186 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
7 years, 3 months ago (2013-09-24 20:40:08 UTC) #1
Elliot Glaysher
7 years, 3 months ago (2013-09-24 20:41:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r225061.

Powered by Google App Engine
This is Rietveld 408576698