Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 24365011: Position absolute is not working properly in RTL mode for vertical scroll contents (Closed)

Created:
7 years, 2 months ago by pals
Modified:
7 years, 2 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Position absolute is not working properly in RTL mode for vertical scroll contents BUG=129746 Positioned elements should consider verticalScrollWidth while calculating position if shouldPlaceBlockDirectionScrollbarOnLogicalLeft() is true. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158423

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased again #

Patch Set 4 : NeedsRebaseLine for Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/scrollbars/rtl/div-absolute-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/gpu/compositedscrolling/scrollbars/rtl/div-absolute-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
pals
Please review.
7 years, 2 months ago (2013-09-24 13:47:45 UTC) #1
ojan
lgtm
7 years, 2 months ago (2013-09-25 00:05:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/24365011/1
7 years, 2 months ago (2013-09-25 00:07:06 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-09-25 00:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/24365011/7001
7 years, 2 months ago (2013-09-25 07:14:15 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout&number=10301
7 years, 2 months ago (2013-09-25 09:11:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/24365011/23001
7 years, 2 months ago (2013-09-26 11:31:51 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=7284
7 years, 2 months ago (2013-09-26 13:41:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/24365011/38001
7 years, 2 months ago (2013-09-27 06:00:25 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 07:14:01 UTC) #10
Message was sent while issue was closed.
Change committed as 158423

Powered by Google App Engine
This is Rietveld 408576698