Improve extension uninstall flow

chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 66 matching lines @@
 
   // Called when the ExtensionUninstallDialog has been destroyed to make sure
   // we invalidate pointers.
   void DialogDestroyed() { dialog_ = NULL; }
 
  private:
   // views::DialogDelegate:
   virtual base::string16 GetDialogButtonLabel(
       ui::DialogButton button) const OVERRIDE;
   virtual int GetDefaultDialogButton() const OVERRIDE {
-    return ui::DIALOG_BUTTON_CANCEL;
+    // Default to accept when triggered via chrome://extensions page.
+    return triggering_extension_ ?

[msw - DO NOT USE, 2014/04/19 00:52:58]

nit: seems like you could just keep a bool |triggered_via_extension_|, or an int
|default_dialog_button_| (that's changed on
ExtensionUninstallDialogDelegateView), instead of keeping a pointer to the
extension object.

[Isaac (away), 2014/04/19 01:06:19]

Switched to bool.

+        ui::DIALOG_BUTTON_CANCEL : ui::DIALOG_BUTTON_OK;
   }
   virtual bool Accept() OVERRIDE;
   virtual bool Cancel() OVERRIDE;
 
   // views::WidgetDelegate:
   virtual ui::ModalType GetModalType() const OVERRIDE {
     return ui::MODAL_TYPE_WINDOW;
   }
   virtual base::string16 GetWindowTitle() const OVERRIDE;
 
   // views::View:
   virtual gfx::Size GetPreferredSize() OVERRIDE;
 
   virtual void Layout() OVERRIDE;
 
   ExtensionUninstallDialogViews* dialog_;
 
   views::ImageView* icon_;
   views::Label* heading_;
+  const extensions::Extension* triggering_extension_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionUninstallDialogDelegateView);
 };
 
 ExtensionUninstallDialogViews::ExtensionUninstallDialogViews(
     Profile* profile,
     Browser* browser,
     ExtensionUninstallDialog::Delegate* delegate)
     : ExtensionUninstallDialog(profile, browser, delegate),
       view_(NULL),
@@ skipping 48 matching lines @@
     size = gfx::Size(kIconSize, kIconSize);
   icon_ = new views::ImageView();
   icon_->SetImageSize(size);
   icon_->SetImage(*icon);
   AddChildView(icon_);
 
   heading_ = new views::Label(base::UTF8ToUTF16(dialog_->GetHeadingText()));
   heading_->SetMultiLine(true);
   heading_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   AddChildView(heading_);
+
+  triggering_extension_ = triggering_extension;
 }
 
 ExtensionUninstallDialogDelegateView::~ExtensionUninstallDialogDelegateView() {
 }
 
 base::string16 ExtensionUninstallDialogDelegateView::GetDialogButtonLabel(
     ui::DialogButton button) const {
   return l10n_util::GetStringUTF16((button == ui::DIALOG_BUTTON_OK) ?
       IDS_EXTENSION_PROMPT_UNINSTALL_BUTTON : IDS_CANCEL);
 }
@@ skipping 55 matching lines @@
 
 }  // namespace
 
 // static
 ExtensionUninstallDialog* ExtensionUninstallDialog::Create(
     Profile* profile,
     Browser* browser,
     Delegate* delegate) {
   return new ExtensionUninstallDialogViews(profile, browser, delegate);
 }