net/spdy/spdy_frame_builder.cc - Issue 243643002: Refactor RST_STREAM status code handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_frame_builder.cc

Issue 243643002: Refactor RST_STREAM status code handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Expanded FRAME_TOO_LARGE/FRAME_SIZE_ERROR comment. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_frame_builder.cc

diff --git a/net/spdy/spdy_frame_builder.cc b/net/spdy/spdy_frame_builder.cc

index 5b084126fd9a2f5487723db083d64407f11a6142..7ea7716b41bfff075e51f796415e8130d2f209f0 100644

--- a/net/spdy/spdy_frame_builder.cc

+++ b/net/spdy/spdy_frame_builder.cc

@@ -158,7 +158,7 @@ bool SpdyFrameBuilder::RewriteLength(const SpdyFramer& framer) {

bool SpdyFrameBuilder::OverwriteLength(const SpdyFramer& framer,

size_t length) {

if (framer.protocol_version() < 4) {

- DCHECK_GT(framer.GetFrameMaximumSize() - framer.GetFrameMinimumSize(),

+ DCHECK_GE(framer.GetFrameMaximumSize() - framer.GetFrameMinimumSize(),

length);

} else {

DCHECK_GE(framer.GetFrameMaximumSize(), length);

« no previous file with comments | « no previous file | net/spdy/spdy_framer.cc » ('j') | no next file with comments »