Refactor RST_STREAM status code handling.

net/spdy/spdy_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_SESSION_H_
 #define NET_SPDY_SPDY_SESSION_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 77 matching lines @@
   STATUS_CODE_PROTOCOL_ERROR = 11,
   STATUS_CODE_INVALID_STREAM = 12,
   STATUS_CODE_REFUSED_STREAM = 13,
   STATUS_CODE_UNSUPPORTED_VERSION = 14,
   STATUS_CODE_CANCEL = 15,
   STATUS_CODE_INTERNAL_ERROR = 16,
   STATUS_CODE_FLOW_CONTROL_ERROR = 17,
   STATUS_CODE_STREAM_IN_USE = 18,
   STATUS_CODE_STREAM_ALREADY_CLOSED = 19,
   STATUS_CODE_INVALID_CREDENTIALS = 20,
-  STATUS_CODE_FRAME_TOO_LARGE = 21,
+  STATUS_CODE_FRAME_SIZE_ERROR = 21,
+  STATUS_CODE_SETTINGS_TIMEOUT = 32,
+  STATUS_CODE_CONNECT_ERROR = 33,
+  STATUS_CODE_ENHANCE_YOUR_CALM = 34,

[jar (doing other things), 2014/04/22 00:02:59]

What is this name meant to mean??  The others seem much more apparent.

[Johnny, 2014/04/22 00:31:27]

This is specification authors having fun :) See
http://http2.github.io/http2-spec/#ErrorCodes

ENHANCE_YOUR_CALM: "The endpoint detected that its peer is exhibiting a behavior
over a given amount of time that has caused it to refuse to process further
frames"

Also mapped (by some implementations) to HTTP status code 420:
http://httpstatus.es/420

[jar (doing other things), 2014/04/25 16:03:45]

IMO, you should map this to a meaningful name, and only comment that the "having
fun authors" use this meaningless term in the spec.  You would IMO do the same
thing if the spec authors named it with a meaningless hex sequence, etc.  We
need meaningful names for variables and enums.... and this does not seem to
reach that bar.

+
   // SpdySession errors
   PROTOCOL_ERROR_UNEXPECTED_PING = 22,
   PROTOCOL_ERROR_RST_STREAM_FOR_NON_ACTIVE_STREAM = 23,
   PROTOCOL_ERROR_SPDY_COMPRESSION_FAILURE = 24,
   PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION = 25,
   PROTOCOL_ERROR_SYN_REPLY_NOT_RECEIVED = 26,
   PROTOCOL_ERROR_INVALID_WINDOW_UPDATE_SIZE = 27,
   PROTOCOL_ERROR_RECEIVE_WINDOW_VIOLATION = 28,
 
   // Next free value.
-  NUM_SPDY_PROTOCOL_ERROR_DETAILS = 32,
+  NUM_SPDY_PROTOCOL_ERROR_DETAILS = 35,
 };
 SpdyProtocolErrorDetails NET_EXPORT_PRIVATE MapFramerErrorToProtocolError(
     SpdyFramer::SpdyError);
 SpdyProtocolErrorDetails NET_EXPORT_PRIVATE MapRstStreamStatusToProtocolError(
     SpdyRstStreamStatus);
 
 // If these compile asserts fail then SpdyProtocolErrorDetails needs
 // to be updated with new values, as do the mapping functions above.
 COMPILE_ASSERT(12 == SpdyFramer::LAST_ERROR,
                SpdyProtocolErrorDetails_SpdyErrors_mismatch);
-COMPILE_ASSERT(12 == RST_STREAM_NUM_STATUS_CODES,
+COMPILE_ASSERT(15 == RST_STREAM_NUM_STATUS_CODES,
                SpdyProtocolErrorDetails_RstStreamStatus_mismatch);
 
 // A helper class used to manage a request to create a stream.
 class NET_EXPORT_PRIVATE SpdyStreamRequest {
  public:
   SpdyStreamRequest();
   // Calls CancelRequest().
   ~SpdyStreamRequest();
 
   // Starts the request to create a stream. If OK is returned, then
@@ skipping 989 matching lines @@
   // This SPDY proxy is allowed to push resources from origins that are
   // different from those of their associated streams.
   HostPortPair trusted_spdy_proxy_;
 
   TimeFunc time_func_;
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_SESSION_H_