Issue 24364005: Update webrtc to r4819.

Issue 24364005: Update webrtc to r4819. (Closed)

Created:
7 years, 3 months ago by Mallinath (Gone from Chromium)

Modified:
7 years, 3 months ago

Reviewers:
Sergey Ulanov, Ronghua Wu (Left Chromium)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, jam, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Update webrtc to r4819. R=ronghuawu@chromium.org, sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224826

Patch Set 1 #

Patch Set 2 : #

Total comments: 9

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -26 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/p2p/ipc_socket_factory.cc	View	1 2	2 chunks	+9 lines, -5 lines	0 comments	Download
M	jingle/glue/channel_socket_adapter.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	jingle/glue/channel_socket_adapter_unittest.cc	View		3 chunks	+8 lines, -3 lines	0 comments	Download
M	jingle/glue/fake_socket_factory.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	jingle/glue/fake_socket_factory.cc	View	1 2	1 chunk	+5 lines, -3 lines	0 comments	Download
M	remoting/client/plugin/pepper_packet_socket_factory.cc	View	1 2	3 chunks	+8 lines, -4 lines	0 comments	Download
M	remoting/jingle_glue/chromium_socket_factory.cc	View	1 2	3 chunks	+12 lines, -4 lines	0 comments	Download
M	remoting/jingle_glue/chromium_socket_factory_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/libjingle/README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm https://codereview.chromium.org/24364005/diff/32001/content/renderer/p2p/ipc_socket_factory.cc File content/renderer/p2p/ipc_socket_factory.cc (right): https://codereview.chromium.org/24364005/diff/32001/content/renderer/p2p/ipc_socket_factory.cc#newcode215 content/renderer/p2p/ipc_socket_factory.cc:215: talk_base::DiffServCodePoint /*dscp*/) { Does the name need to ...

7 years, 3 months ago (2013-09-23 22:32:35 UTC) #3

Mallinath (Gone from Chromium)

https://codereview.chromium.org/24364005/diff/32001/content/renderer/p2p/ipc_socket_factory.cc File content/renderer/p2p/ipc_socket_factory.cc (right): https://codereview.chromium.org/24364005/diff/32001/content/renderer/p2p/ipc_socket_factory.cc#newcode215 content/renderer/p2p/ipc_socket_factory.cc:215: talk_base::DiffServCodePoint /*dscp*/) { Isn't the style where you will ...

7 years, 3 months ago (2013-09-23 22:38:14 UTC) #4

Mallinath (Gone from Chromium)

Committed patchset #3 manually as r224826 (presubmit successful).

7 years, 3 months ago (2013-09-23 23:12:02 UTC) #6

Sergey Ulanov

7 years, 3 months ago (2013-09-23 23:16:07 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/24364005/diff/32001/content/renderer/p2p/ipc_...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/24364005/diff/32001/content/renderer/p2p/ipc_...
content/renderer/p2p/ipc_socket_factory.cc:215: talk_base::DiffServCodePoint
/*dscp*/) {
On 2013/09/23 22:38:14, mallinath2 wrote:
> Isn't the style where you will not use the variable in the method? Done.

It may be necessary for compilers that warn about unused parameters, but such
warnings should be disabled in chrome.

Expand Messages | Collapse Messages