Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2042)

Unified Diff: content/public/common/push_messaging_status.cc

Issue 2436393002: Disallow repeated PushManager.subscribes with different sender ids (Closed)
Patch Set: rebase and comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/push_messaging_status.cc
diff --git a/content/public/common/push_messaging_status.cc b/content/public/common/push_messaging_status.cc
index 09a56f4be8645bb88ca4732f5964fb464166ad49..e0080d569d48ebd5ba35643a724615d9978c827c 100644
--- a/content/public/common/push_messaging_status.cc
+++ b/content/public/common/push_messaging_status.cc
@@ -52,6 +52,10 @@ const char* PushRegistrationStatusToString(PushRegistrationStatus status) {
case PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING:
return "Registration failed - missing applicationServerKey, and manifest "
"empty or missing";
+
+ case PUSH_REGISTRATION_STATUS_SENDER_ID_MISMATCH:
+ return "Registration failed - A subscription with a different sender ID "
johnme 2016/11/08 13:39:55 Let's be explicit. How about "A subscription with
awdf 2016/11/08 14:39:16 ok - how about "Registration failed - A subscripti
+ "already exists";
}
NOTREACHED();
return "";

Powered by Google App Engine
This is Rietveld 408576698