Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2436333002: Add kernel generation to the compiler/perf script (Closed)

Created:
4 years, 2 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : cl review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -11 lines) Patch
M pkg/compiler/tool/perf.dart View 1 3 chunks +96 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
4 years, 2 months ago (2016-10-21 15:21:11 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2436333002/diff/1/pkg/compiler/tool/perf.dart File pkg/compiler/tool/perf.dart (right): https://codereview.chromium.org/2436333002/diff/1/pkg/compiler/tool/perf.dart#newcode401 pkg/compiler/tool/perf.dart:401: dynamic b = backend; don't use single-letter variable ...
4 years, 2 months ago (2016-10-21 16:41:48 UTC) #3
Siggi Cherem (dart-lang)
Thanks Harry! https://codereview.chromium.org/2436333002/diff/1/pkg/compiler/tool/perf.dart File pkg/compiler/tool/perf.dart (right): https://codereview.chromium.org/2436333002/diff/1/pkg/compiler/tool/perf.dart#newcode401 pkg/compiler/tool/perf.dart:401: dynamic b = backend; On 2016/10/21 16:41:47, ...
4 years, 2 months ago (2016-10-21 17:01:40 UTC) #4
Siggi Cherem (dart-lang)
4 years, 2 months ago (2016-10-21 17:02:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
02a14cd93761a759fcb53678c0f2b84a13cce5b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698