use the right NativeTheme on bubbles + dialogs on Aura Linux

ui/views/controls/menu/menu_scroll_view_container.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_scroll_view_container.h"
 
 #include "third_party/skia/include/core/SkPaint.h"
 #include "third_party/skia/include/core/SkPath.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/gfx/canvas.h"
@@ skipping 263 matching lines @@
   arrow_ = BubbleBorder::NONE;
   bubble_border_ = NULL;
 
   const MenuConfig& menu_config =
       content_view_->GetMenuItem()->GetMenuConfig();
 
   bool use_border = true;
   int padding = menu_config.corner_radius > 0 ?
         kBorderPaddingDueToRoundedCorners : 0;
 
+#if !(defined(OS_LINUX) && !defined(OS_CHROMEOS))

[Elliot Glaysher, 2014/04/21 22:43:20]

If you're bracing these with #if checks, you probably also want to take care of
the one in menu_config_views.cc?

[Evan Stade, 2014/04/22 18:33:22]

No, I think menu_config_views.cc is OK as-is. I just blocked this out because
there's actually no shadow on linux (at least on my setup), so not having a
border looks pretty weird.

[Elliot Glaysher, 2014/04/22 19:48:27]

I can see us wanting to use the aura colors. However, I don't think we want to
use the extremely tall chromeos menus. We make an exception on Windows, and I
think we should do that here.

   if (menu_config.native_theme == ui::NativeThemeAura::instance()) {
     // In case of NativeThemeAura the border gets drawn with the shadow.
     // Furthermore no additional padding is wanted.
     use_border = false;
     padding = 0;
   }
+#endif
 
   int top = menu_config.menu_vertical_border_size + padding;
   int left = menu_config.menu_horizontal_border_size + padding;
   int bottom = menu_config.menu_vertical_border_size + padding;
   int right = menu_config.menu_horizontal_border_size + padding;
 
   if (use_border) {
     SetBorder(views::Border::CreateBorderPainter(
         new views::RoundRectPainter(
             menu_config.native_theme->GetSystemColor(
@@ skipping 24 matching lines @@
     case views::MenuItemView::BUBBLE_ABOVE:
       return BubbleBorder::BOTTOM_CENTER;
     case views::MenuItemView::BUBBLE_BELOW:
       return BubbleBorder::TOP_CENTER;
     default:
       return BubbleBorder::NONE;
   }
 }
 
 }  // namespace views