Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
NOTRY=true (to workaround OOM of android bot)

Committed: https://crrev.com/a4969c67949640d4a7fbe2a2ea91cb4506aaa218
Cr-Commit-Position: refs/heads/master@{#427177}

[Xianzhu, 2016-10-21 05:57:25]

Description was changed from

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172,598762
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
==========

to

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
==========

[Xianzhu, 2016-10-21 05:58:57]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:59:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 07:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 07:36:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-10-21 21:27:01]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 21:27:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-10-21 21:28:10]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-10-21 22:40:32]

lgtm

https://codereview.chromium.org/2436283002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2436283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:2043: const LayoutObject*
o = container(ancestor, &ancestorSkipped);
Could you take this opportunity to rename to containingBlock?

[Xianzhu, 2016-10-21 22:52:00]

https://codereview.chromium.org/2436283002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2436283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:2043: const LayoutObject*
o = container(ancestor, &ancestorSkipped);
On 2016/10/21 22:40:32, chrishtr wrote:
> Could you take this opportunity to rename to containingBlock?

I feel using containingBlock is confusing for now because we are still using
"containingBlock" and "container" for different purposes. Can we use "container"
for now before we replace all "container"s with "containingBlock"s?

[chrishtr, 2016-10-21 22:54:15]

On 2016/10/21 at 22:52:00, wangxianzhu wrote:
>
https://codereview.chromium.org/2436283002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):
> 
>
https://codereview.chromium.org/2436283002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/LayoutObject.cpp:2043: const
LayoutObject* o = container(ancestor, &ancestorSkipped);
> On 2016/10/21 22:40:32, chrishtr wrote:
> > Could you take this opportunity to rename to containingBlock?
> 
> I feel using containingBlock is confusing for now because we are still using
"containingBlock" and "container" for different purposes. Can we use "container"
for now before we replace all "container"s with "containingBlock"s?

Sure, good point.

[commit-bot: I haz the power, 2016-10-21 22:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:57:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Xianzhu, 2016-10-22 00:00:01]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-22 00:00:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2436283002/#ps60001
(title: "s/o/conainer/")

[commit-bot: I haz the power, 2016-10-22 00:00:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 00:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 00:04:49]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-10-24 16:21:58]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-24 16:21:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2436283002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-24 16:22:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 17:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 17:55:54]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-10-24 18:19:02]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-24 18:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2436283002/#ps100001
(title: "Rebaseline after rebase")

[commit-bot: I haz the power, 2016-10-24 18:19:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:29:48]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Xianzhu, 2016-10-24 23:07:00]

Description was changed from

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
==========

to

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
NOTRY=true (to workaround OOM of android bot)
==========

[Xianzhu, 2016-10-24 23:07:05]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 23:16:46]

Description was changed from

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
NOTRY=true (to workaround OOM of android bot)
==========

to

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
NOTRY=true (to workaround OOM of android bot)
==========

[commit-bot: I haz the power, 2016-10-24 23:16:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-24 23:18:28]

Description was changed from

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
NOTRY=true (to workaround OOM of android bot)
==========

to

==========
Fix LayoutObject::mapLocalToAncestor() for fixed under absolute

When mapping from a fixed to an absolute ancestor, mapLocalToAncestor()
deals with the case that the ancestor is skipped by fixed's container,
but forgot to adjust fixed-position offset.

Also fix the similar issue of mapAncestorToLocal().

BUG=656172
TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView
TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html
NOTRY=true (to workaround OOM of android bot)

Committed: https://crrev.com/a4969c67949640d4a7fbe2a2ea91cb4506aaa218
Cr-Commit-Position: refs/heads/master@{#427177}
==========

[commit-bot: I haz the power, 2016-10-24 23:18:29]

Patchset 6 (id:??) landed as
https://crrev.com/a4969c67949640d4a7fbe2a2ea91cb4506aaa218
Cr-Commit-Position: refs/heads/master@{#427177}