Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: net/cert/asn1_util.h

Issue 2436233002: Record UMA metrics for Must-Staple certificates on private roots (Closed)
Patch Set: Add another histogram for OCSP response status Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/cert/asn1_util.cc » ('j') | net/cert/asn1_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_CERT_ASN1_UTIL_H_ 5 #ifndef NET_CERT_ASN1_UTIL_H_
6 #define NET_CERT_ASN1_UTIL_H_ 6 #define NET_CERT_ASN1_UTIL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/strings/string_piece.h" 10 #include "base/strings/string_piece.h"
(...skipping 25 matching lines...) Expand all
36 // 36 //
37 // CRLs that use an alternative issuer are also omitted. 37 // CRLs that use an alternative issuer are also omitted.
38 // 38 //
39 // The nested set of GeneralNames is flattened into a single list because 39 // The nested set of GeneralNames is flattened into a single list because
40 // having several CRLs with one location is equivalent to having one CRL with 40 // having several CRLs with one location is equivalent to having one CRL with
41 // several locations as far as a CRL filter is concerned. 41 // several locations as far as a CRL filter is concerned.
42 NET_EXPORT_PRIVATE bool ExtractCRLURLsFromDERCert( 42 NET_EXPORT_PRIVATE bool ExtractCRLURLsFromDERCert(
43 base::StringPiece cert, 43 base::StringPiece cert,
44 std::vector<base::StringPiece>* urls_out); 44 std::vector<base::StringPiece>* urls_out);
45 45
46 // HasTLSFeatureExtensions parses the DER encoded certificate in |cert|
eroman 2016/10/21 01:49:23 typo: HasTLSFeatureExtension
estark 2016/10/21 02:11:29 Done.
47 // and extracts the TLS feature extension
48 // (https://tools.ietf.org/html/rfc7633) if present. On successful
eroman 2016/10/21 01:49:22 Thanks for including the RFC reference in the comm
49 // return, |*has_tls_feature_extension| to true if the TLS feature
eroman 2016/10/21 01:49:23 Can you re-work the wording on this? Feels like so
estark 2016/10/21 02:11:29 Done.
50 // extension was present and false otherwise.
51 NET_EXPORT_PRIVATE bool HasTLSFeatureExtension(base::StringPiece cert,
eroman 2016/10/21 01:49:22 API question: Instead of two bool outputs, can the
estark 2016/10/21 02:11:29 Yeah, I think that'll work. Done.
52 bool* has_tls_feature_extension);
53
46 } // namespace asn1 54 } // namespace asn1
47 55
48 } // namespace net 56 } // namespace net
49 57
50 #endif // NET_CERT_ASN1_UTIL_H_ 58 #endif // NET_CERT_ASN1_UTIL_H_
OLDNEW
« no previous file with comments | « no previous file | net/cert/asn1_util.cc » ('j') | net/cert/asn1_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698