Record UMA metrics for Must-Staple certificates on private roots

net/cert/asn1_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_ASN1_UTIL_H_
 #define NET_CERT_ASN1_UTIL_H_
 
 #include <vector>
 
 #include "base/strings/string_piece.h"
@@ skipping 25 matching lines @@
 //
 // CRLs that use an alternative issuer are also omitted.
 //
 // The nested set of GeneralNames is flattened into a single list because
 // having several CRLs with one location is equivalent to having one CRL with
 // several locations as far as a CRL filter is concerned.
 NET_EXPORT_PRIVATE bool ExtractCRLURLsFromDERCert(
     base::StringPiece cert,
     std::vector<base::StringPiece>* urls_out);
 
+// HasTLSFeatureExtensions parses the DER encoded certificate in |cert|

[eroman, 2016/10/21 01:49:23]

typo: HasTLSFeatureExtension

[estark, 2016/10/21 02:11:29]

Done.

+// and extracts the TLS feature extension
+// (https://tools.ietf.org/html/rfc7633) if present. On successful

[eroman, 2016/10/21 01:49:22]

Thanks for including the RFC reference in the comment.

+// return, |*has_tls_feature_extension| to true if the TLS feature

[eroman, 2016/10/21 01:49:23]

Can you re-work the wording on this? Feels like something is missing.

[estark, 2016/10/21 02:11:29]

Done.

+// extension was present and false otherwise.
+NET_EXPORT_PRIVATE bool HasTLSFeatureExtension(base::StringPiece cert,

[eroman, 2016/10/21 01:49:22]

API question: Instead of two bool outputs, can the API be:
   bool HasTLSFeatureExtension(base::StringPiece)

The meaning of false here would now include any failures parsing -- which for
the consumers I don't think is of particular interest, nor for that matter is
likely to be reached.

WDYT?

[estark, 2016/10/21 02:11:29]

Yeah, I think that'll work. Done.

+                                               bool* has_tls_feature_extension);
+
 } // namespace asn1
 
 } // namespace net
 
 #endif // NET_CERT_ASN1_UTIL_H_