Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2436223004: Use the serviceworker with mojo by default (Closed)

Created:
4 years, 2 months ago by shimazu
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit), horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, shimazu+serviceworker_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, tzik, darin (slow to review), blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the serviceworker with mojo by default This patch changes --mojo-service-worker to --disable-mojo-service-worker. Let's try mojo for the service worker. BUG=629701 Committed: https://crrev.com/391fa63bcefd25b35addf678356828dded5ae71e Cr-Commit-Position: refs/heads/master@{#427013}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -51 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 2 chunks +3 lines, -17 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_test_utils.h View 1 chunk +3 lines, -7 lines 0 comments Download
M content/common/service_worker/service_worker_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/disable-mojo-service-worker/http/tests/serviceworker/README.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/mojo-service-worker/http/tests/serviceworker/README.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
shimazu
ptal
4 years, 2 months ago (2016-10-21 05:16:44 UTC) #2
horo
lgtm great work!
4 years, 2 months ago (2016-10-21 06:55:07 UTC) #3
shimazu
avi@: Could you review changes in the following? - content/browser/renderer_host/render_process_host_impl.cc - content/public
4 years, 2 months ago (2016-10-21 06:57:19 UTC) #7
Avi (use Gerrit)
On 2016/10/21 06:57:19, shimazu wrote: > avi@: Could you review changes in the following? > ...
4 years, 2 months ago (2016-10-21 13:02:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436223004/1
4 years, 2 months ago (2016-10-24 01:21:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/287543)
4 years, 2 months ago (2016-10-24 01:42:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436223004/20001
4 years, 2 months ago (2016-10-24 02:07:36 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-24 04:17:57 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/391fa63bcefd25b35addf678356828dded5ae71e Cr-Commit-Position: refs/heads/master@{#427013}
4 years, 2 months ago (2016-10-24 04:20:26 UTC) #20
dmazzoni
4 years, 1 month ago (2016-10-24 16:44:07 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2443983002/ by dmazzoni@chromium.org.

The reason for reverting is: I think this is causing
InstallableManagerBrowserTest.CheckManifest404 to crash, see
http://crbug.com/658702
.

Powered by Google App Engine
This is Rietveld 408576698