Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: content/browser/loader/intercepting_resource_handler.h

Issue 2436163002: When InterceptingResourceHandler swaps in a handler, call OnWillStart. (Closed)
Patch Set: Update comments, remove prototype for method that never existed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/loader/intercepting_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/intercepting_resource_handler.h
diff --git a/content/browser/loader/intercepting_resource_handler.h b/content/browser/loader/intercepting_resource_handler.h
index 937b8d7237df1f9e4525c76a09ea04e96a674848..3c796a406f67d2eb44609979529ba7c5a382470d 100644
--- a/content/browser/loader/intercepting_resource_handler.h
+++ b/content/browser/loader/intercepting_resource_handler.h
@@ -81,11 +81,17 @@ class CONTENT_EXPORT InterceptingResourceHandler
// Resume().
SENDING_PAYLOAD_TO_OLD_HANDLER,
- // The InterceptingResourcHandler is notifying OnResponseStarted to the new
- // handler and waiting for its completion via Resume(). After the
- // completion, the InterceptingResourcHandler will transit to
+ // The InterceptingResourcHandler is calling the new handler's
+ // OnResponseStarted method and waiting for its completion via Resume().
+ // After completion, the InterceptingResourceHandler will transition to
+ // SENDING_ON_RESPONSE_STARTED_TO_NEW_HANDLER on success.
+ SENDING_ON_WILL_START_TO_NEW_HANDLER,
+
+ // The InterceptingResourcHandler is calling the new handler's
+ // OnResponseStarted method and waiting for its completion via Resume().
+ // After completion, the InterceptingResourceHandler will transition to
// WAITING_FOR_ON_READ_COMPLETED on success.
- NOTIFYING_ON_RESPONSE_STARTED_TO_NEW_HANDLER,
+ SENDING_ON_RESPONSE_STARTED_TO_NEW_HANDLER,
// The InterceptingResourcHandler is waiting for OnReadCompleted to be
// called.
@@ -110,7 +116,7 @@ class CONTENT_EXPORT InterceptingResourceHandler
// The return value and |defer| has the same meaning as DoLoop.
bool SendPayloadToOldHandler(bool* defer);
bool SendFirstReadBufferToNewHandler(bool* defer);
- bool SendCompletionToOldHandler(bool* defer);
+ bool SendOnResponseStartedToNewHandler(bool* defer);
State state_ = State::STARTING;
« no previous file with comments | « no previous file | content/browser/loader/intercepting_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698