Remove FWL globals.

Remove FWL globals.

This CL removes the FWL_GetApp, FWL_SetApp and FWL_GetWidgetAdapter methods.
In the process it changes the various Initialize methods to return void.

Committed: https://pdfium.googlesource.com/pdfium/+/20855384b8149a631c3c1d229551523c12eb767b

[dsinclair, 2016-10-20 17:57:19]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 17:57:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-20 18:05:02]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-10-20 18:05:03]

PTAL.

[dsinclair, 2016-10-28 20:42:05]

On 2016/10/20 18:05:03, OOO to 2016-10-31 (dsinclair) wrote:
> PTAL.

ping.

[Tom Sepez, 2016-10-28 23:11:48]

lgtm

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:35: CXFA_FFApp* GetAdapterNative() const;
nit: do we want these inline as well? Or should GetNoteDriver() be in the .cpp
too

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_combo...
File xfa/fwl/core/ifwl_combolist.cpp (right):

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_combo...
xfa/fwl/core/ifwl_combolist.cpp:24: m_pDelegate = new
CFWL_ComboListImpDelegate(this);
nit: maybe m_pDelegate should be unique_ptr.  Also it seems wrong for the
subclass to be manipulating the superclass instance variables rather than
calling a SetDelegate() method in the superclass.

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_combo...
xfa/fwl/core/ifwl_combolist.cpp:29: m_pDelegate = nullptr;
nit. e.g. SetDelegate(nullptr);

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widget.h:204: const IFWL_App* m_pOwnerApp;
nit: is this const IFWL_App* const m_pOwnerApp; ?

[dsinclair, 2016-10-31 14:13:18]

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:35: CXFA_FFApp* GetAdapterNative() const;
On 2016/10/28 23:11:47, Tom Sepez wrote:
> nit: do we want these inline as well? Or should GetNoteDriver() be in the .cpp
> too

Inlined.

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_combo...
File xfa/fwl/core/ifwl_combolist.cpp (right):

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_combo...
xfa/fwl/core/ifwl_combolist.cpp:24: m_pDelegate = new
CFWL_ComboListImpDelegate(this);
On 2016/10/28 23:11:47, Tom Sepez wrote:
> nit: maybe m_pDelegate should be unique_ptr.  Also it seems wrong for the
> subclass to be manipulating the superclass instance variables rather than
> calling a SetDelegate() method in the superclass.

Ack. I'm working on that, will be in a follow up CL. I think we need to pass it
down the constructors as it does some weird stuff currently.

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_combo...
xfa/fwl/core/ifwl_combolist.cpp:29: m_pDelegate = nullptr;
On 2016/10/28 23:11:47, Tom Sepez wrote:
> nit. e.g. SetDelegate(nullptr);

Acknowledged.

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2436103002/diff/40001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widget.h:204: const IFWL_App* m_pOwnerApp;
On 2016/10/28 23:11:47, Tom Sepez wrote:
> nit: is this const IFWL_App* const m_pOwnerApp; ?

Done.   C++, just add const before every symbol .....

[dsinclair, 2016-10-31 14:13:23]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-31 14:13:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2436103002/#ps80001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-10-31 14:13:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 14:29:38]

Description was changed from

==========
Remove FWL globals.

This CL removes the FWL_GetApp, FWL_SetApp and FWL_GetWidgetAdapter methods.
In the process it changes the various Initialize methods to return void.
==========

to

==========
Remove FWL globals.

This CL removes the FWL_GetApp, FWL_SetApp and FWL_GetWidgetAdapter methods.
In the process it changes the various Initialize methods to return void.

Committed:
https://pdfium.googlesource.com/pdfium/+/20855384b8149a631c3c1d229551523c12eb...
==========

[commit-bot: I haz the power, 2016-10-31 14:29:39]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/20855384b8149a631c3c1d229551523c12eb...