Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_store.h

Issue 2436023002: Remove stl_util's deletion function use from chrome/browser/extensions/api/content_settings. (Closed)
Patch Set: reverse sort Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/content_settings/content_settings_store.h
diff --git a/chrome/browser/extensions/api/content_settings/content_settings_store.h b/chrome/browser/extensions/api/content_settings/content_settings_store.h
index f0f9e39bee280dc660aa552aa432f5960840d6f9..9ddf464daba39065576917450eed16fb18c2b875 100644
--- a/chrome/browser/extensions/api/content_settings/content_settings_store.h
+++ b/chrome/browser/extensions/api/content_settings/content_settings_store.h
@@ -6,7 +6,9 @@
#define CHROME_BROWSER_EXTENSIONS_API_CONTENT_SETTINGS_CONTENT_SETTINGS_STORE_H_
#include <map>
+#include <memory>
#include <string>
+#include <vector>
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -112,7 +114,7 @@ class ContentSettingsStore
struct ExtensionEntry;
- typedef std::multimap<base::Time, ExtensionEntry*> ExtensionEntryMap;
+ using ExtensionEntries = std::vector<std::unique_ptr<ExtensionEntry>>;
virtual ~ContentSettingsStore();
@@ -129,10 +131,12 @@ class ContentSettingsStore
bool OnCorrectThread();
- ExtensionEntryMap::iterator FindEntry(const std::string& ext_id);
- ExtensionEntryMap::const_iterator FindEntry(const std::string& ext_id) const;
+ ExtensionEntries::iterator FindEntry(const std::string& ext_id);
+ ExtensionEntries::const_iterator FindEntry(const std::string& ext_id) const;
- ExtensionEntryMap entries_;
+ // The entries. Maintained in reverse-chronological order (newest items first)
Devlin 2016/12/14 15:54:01 I wonder if the part about reverse-chronological o
Avi (use Gerrit) 2016/12/14 19:29:06 Done.
+ // to facilitate search.
+ ExtensionEntries entries_;
base::ObserverList<Observer, false> observers_;

Powered by Google App Engine
This is Rietveld 408576698