Issue 24360019: Speed up ArrayBuffer/typed array/DataView properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24360019: Speed up ArrayBuffer/typed array/DataView properties. (Closed)

Created:
7 years, 3 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 2 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Speed up ArrayBuffer/typed array/DataView properties. Optimizes byteLength, byteOffset, buffer and other properties on ArrayBuffer, typed arrays and DataView into simple field loads. Some unification with the way Array.length and String.length are treated. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16930

Patch Set 1 #

Patch Set 2 : After self-review #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -60 lines)			Patch
M	src/accessors.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/accessors.cc	View		1 chunk	+55 lines, -0 lines	0 comments	Download
M	src/heap.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/hydrogen.h	View	1	4 chunks	+29 lines, -15 lines	0 comments	Download
M	src/hydrogen.cc	View		4 chunks	+7 lines, -26 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/ic.cc	View	1	1 chunk	+10 lines, -11 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit. I like this change. https://codereview.chromium.org/24360019/diff/2/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/24360019/diff/2/src/ic.cc#newcode1351 src/ic.cc:1351: { Remove ...

7 years, 3 months ago (2013-09-24 15:37:38 UTC) #2

Dmitry Lomov (no reviews)

7 years, 2 months ago (2013-09-25 08:19:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16930 (presubmit successful).

Expand Messages | Collapse Messages