Issue 24360011: Cancel JavaScript dialogs when an interstitial appears.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24360011: Cancel JavaScript dialogs when an interstitial appears. (Closed)

Created:
7 years, 3 months ago by Charlie Reis

Modified:
7 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cancel JavaScript dialogs when an interstitial appears. BUG=295695 TEST=See bug for repro steps. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225026

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -0 lines)			Patch
	M	chrome/browser/ui/browser_browsertest.cc	View	1 2 3	2 chunks	+48 lines, -0 lines	0 comments	Download
	M	content/browser/web_contents/web_contents_impl.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Charlie Reis

John, can you take a look? We already suppress JS dialogs if an interstitial is ...

7 years, 3 months ago (2013-09-23 23:45:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/24360011/14001

7 years, 3 months ago (2013-09-24 15:19:13 UTC) #3

Message was sent while issue was closed.

Change committed as 225026