Source/core/rendering/RenderBox.h - Issue 24360004: Use shrink-to-fit for width for Button, input, select, textarea, and legend treat width value of 'a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 24360004: Use shrink-to-fit for width for Button, input, select, textarea, and legend treat width value of 'a… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/replaced/absolute-position-auto-width-and-left-and-right-and-intrinsic-width-quirks-expected.html ('k') | Source/core/rendering/RenderBox.cpp » ('j') | Source/core/rendering/RenderBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index e7b1f005df3a7f2999eb21b6233bf465c2b1a518..b29df57dd38b1f0c184a29c9378ec754e8d818b9 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -411,6 +411,8 @@ public:

// Whether or not the element shrinks to its intrinsic width (rather than filling the width

// of a containing block). HTML4 buttons, <select>s, <input>s, legends, and floating/compact elements do this.

bool sizesLogicalWidthToFitContent(SizeType) const;

+ bool isElementWithIntrinsicWidth() const;

+ void shrinkToFitWidth(const LayoutUnit availableSpace, const LayoutUnit logicalLeftValue, const LayoutUnit bordersPlusPadding, LogicalExtentComputedValues&) const;

ojan 2013/10/16 01:44:43 These should be private?

pals 2013/10/16 07:10:05 Done.

LayoutUnit shrinkLogicalWidthToAvoidFloats(LayoutUnit childMarginStart, LayoutUnit childMarginEnd, const RenderBlock* cb, RenderRegion*) const;