[Findit] Asynchronously process flake reports from chromium-try-flakes.

appengine/findit/waterfall/flake/flake_analysis_service.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from common import constants
 from model.flake.flake_analysis_request import FlakeAnalysisRequest
 from waterfall.flake import initialize_flake_pipeline
 from waterfall.flake import step_mapper
@@ skipping 151 matching lines @@
     return request.version_number, supported_build_step
   else:
     # If no bug is attached to the previous analysis or the new request, or both
     # are attached to the same bug, start a new analysis with a different
     # configuration. For a configuration that was analyzed 7 days ago, reset it
     # to use the new reported step of the same configuration.
     # TODO: move this setting to config.
     return _MergeNewRequestIntoExistingOne(request, previous_request)
 
 
-def _IsAuthorizedUser(user_email):
-  """Returns True if the given user email account  is authorized for access."""
-  return user_email and (
+def IsAuthorizedUser(user_email, is_admin):
+  """Returns True if the given user email account is authorized for access."""
+  return is_admin or (user_email and (
       user_email in constants.WHITELISTED_APP_ACCOUNTS or
-      user_email.endswith('@google.com'))
+      user_email.endswith('@google.com')))
 
 
 def ScheduleAnalysisForFlake(request, user_email, is_admin):
   """Schedules an analysis on the flake in the given request if needed.
 
   Args:
     request (FlakeAnalysisRequest): The request to analyze a flake.
     user_email (str): The email of the requester.
     is_admin (bool): Whether the requester is an admin.
 
   Returns:
     True if an analysis was scheduled; False if a new analysis is not needed;
     None if the user has no permission to.
   """
   assert len(request.build_steps) > 0, 'At least 1 build step is needed!'
 
-  if not is_admin and not _IsAuthorizedUser(user_email):
+  if not IsAuthorizedUser(user_email, is_admin):
     return None
   request.user_emails = [user_email]
 
   manually_triggered = user_email.endswith('@google.com')
 
   for build_step in request.build_steps:
     step_mapper.FindMatchingWaterfallStep(build_step)
 
   version_number, build_step = _CheckForNewAnalysis(request)
   if version_number and build_step:
@@ skipping 13 matching lines @@
       request.put()
       logging.info('A new analysis was triggered successfully: %s',
                    analysis.key)
       return True
     else:
       logging.info('But no new analysis was not triggered!')
   else:
     logging.info('No new analysis is needed: %s', request)
 
   return False