Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 2435973002: INPUT element: code cleanup around setValue(). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
index d70aeafeabb5f7c2b2bf224de80519587434806f..d7d006cb590a1be3c3a4963437892d8276c9b056 100644
--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
@@ -142,14 +142,9 @@ void ColorInputType::createShadowSubtree() {
element().updateView();
}
-void ColorInputType::setValue(const String& value,
- bool valueChanged,
- TextFieldEventBehavior eventBehavior) {
- InputType::setValue(value, valueChanged, eventBehavior);
-
+void ColorInputType::didSetValue(const String&, bool valueChanged) {
if (!valueChanged)
return;
-
element().updateView();
if (m_chooser)
m_chooser->setSelectedColor(valueAsColor());
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/ColorInputType.h ('k') | third_party/WebKit/Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698