Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.h

Issue 2435973002: INPUT element: code cleanup around setValue(). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 void handleMouseDownEvent(MouseEvent*) override; 64 void handleMouseDownEvent(MouseEvent*) override;
65 void handleKeydownEvent(KeyboardEvent*) override; 65 void handleKeydownEvent(KeyboardEvent*) override;
66 LayoutObject* createLayoutObject(const ComputedStyle&) const override; 66 LayoutObject* createLayoutObject(const ComputedStyle&) const override;
67 void createShadowSubtree() override; 67 void createShadowSubtree() override;
68 Decimal parseToNumber(const String&, const Decimal&) const override; 68 Decimal parseToNumber(const String&, const Decimal&) const override;
69 String serialize(const Decimal&) const override; 69 String serialize(const Decimal&) const override;
70 void accessKeyAction(bool sendMouseEvents) override; 70 void accessKeyAction(bool sendMouseEvents) override;
71 void sanitizeValueInResponseToMinOrMaxAttributeChange() override; 71 void sanitizeValueInResponseToMinOrMaxAttributeChange() override;
72 void stepAttributeChanged() override; 72 void stepAttributeChanged() override;
73 void warnIfValueIsInvalid(const String&) const override; 73 void warnIfValueIsInvalid(const String&) const override;
74 void setValue(const String&, 74 void didSetValue(const String&, bool valueChanged) override;
75 bool valueChanged,
76 TextFieldEventBehavior) override;
77 String fallbackValue() const override; 75 String fallbackValue() const override;
78 String sanitizeValue(const String& proposedValue) const override; 76 String sanitizeValue(const String& proposedValue) const override;
79 bool shouldRespectListAttribute() override; 77 bool shouldRespectListAttribute() override;
80 void disabledAttributeChanged() override; 78 void disabledAttributeChanged() override;
81 void listAttributeTargetChanged() override; 79 void listAttributeTargetChanged() override;
82 Decimal findClosestTickMarkValue(const Decimal&) override; 80 Decimal findClosestTickMarkValue(const Decimal&) override;
83 81
84 SliderThumbElement* sliderThumbElement() const; 82 SliderThumbElement* sliderThumbElement() const;
85 Element* sliderTrackElement() const; 83 Element* sliderTrackElement() const;
86 void updateTickMarkValues(); 84 void updateTickMarkValues();
87 85
88 // InputTypeView function: 86 // InputTypeView function:
89 void updateView() override; 87 void updateView() override;
90 88
91 bool m_tickMarkValuesDirty; 89 bool m_tickMarkValuesDirty;
92 Vector<Decimal> m_tickMarkValues; 90 Vector<Decimal> m_tickMarkValues;
93 }; 91 };
94 92
95 } // namespace blink 93 } // namespace blink
96 94
97 #endif // RangeInputType_h 95 #endif // RangeInputType_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698