Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2435973002: INPUT element: code cleanup around setValue(). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 8 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
9 * Copyright (C) 2010 Google Inc. All rights reserved. 9 * Copyright (C) 2010 Google Inc. All rights reserved.
10 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 10 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
(...skipping 1073 matching lines...) Expand 10 before | Expand all | Expand 10 after
1084 if (valueChanged && eventBehavior == DispatchNoEvent) 1084 if (valueChanged && eventBehavior == DispatchNoEvent)
1085 setTextAsOfLastFormControlChangeEvent( 1085 setTextAsOfLastFormControlChangeEvent(
1086 sanitizedValue.isNull() ? defaultValue() : sanitizedValue); 1086 sanitizedValue.isNull() ? defaultValue() : sanitizedValue);
1087 1087
1088 if (!valueChanged) 1088 if (!valueChanged)
1089 return; 1089 return;
1090 1090
1091 notifyFormStateChanged(); 1091 notifyFormStateChanged();
1092 } 1092 }
1093 1093
1094 void HTMLInputElement::setValueInternal(const String& sanitizedValue, 1094 void HTMLInputElement::setNonAttributeValue(const String& sanitizedValue) {
1095 TextFieldEventBehavior eventBehavior) { 1095 // This is a common code for ValueMode::kValue.
1096 DCHECK_EQ(m_inputType->valueMode(), ValueMode::kValue);
1096 m_valueIfDirty = sanitizedValue; 1097 m_valueIfDirty = sanitizedValue;
1097 m_hasDirtyValue = !m_valueIfDirty.isNull(); 1098 m_hasDirtyValue = !m_valueIfDirty.isNull();
1098 setNeedsValidityCheck(); 1099 setNeedsValidityCheck();
1099 if (m_inputType->isSteppable()) { 1100 if (m_inputType->isSteppable()) {
1100 pseudoStateChanged(CSSSelector::PseudoInRange); 1101 pseudoStateChanged(CSSSelector::PseudoInRange);
1101 pseudoStateChanged(CSSSelector::PseudoOutOfRange); 1102 pseudoStateChanged(CSSSelector::PseudoOutOfRange);
1102 } 1103 }
1103 if (document().focusedElement() == this) 1104 if (document().focusedElement() == this)
1104 document() 1105 document()
1105 .frameHost() 1106 .frameHost()
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
1930 1931
1931 bool HTMLInputElement::hasFallbackContent() const { 1932 bool HTMLInputElement::hasFallbackContent() const {
1932 return m_inputTypeView->hasFallbackContent(); 1933 return m_inputTypeView->hasFallbackContent();
1933 } 1934 }
1934 1935
1935 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths) { 1936 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths) {
1936 return m_inputType->setFilesFromPaths(paths); 1937 return m_inputType->setFilesFromPaths(paths);
1937 } 1938 }
1938 1939
1939 } // namespace blink 1940 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | third_party/WebKit/Source/core/html/forms/ColorInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698