chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc - Issue 2435933003: Further refactoring of SBER1 preference usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

Issue 2435933003: Further refactoring of SBER1 preference usage. (Closed)

Patch Set: Order functions alphabetically. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

index e73e6e8ae917bd330b285d4c04af5752cac37e5c..b1799ea8f952ab09682f054876a866eb4a20d8cc 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

@@ -268,8 +268,8 @@ class IncidentReportingServiceTest : public testing::Test {

chrome::RegisterUserProfilePrefs(prefs->registry());

prefs->SetBoolean(prefs::kSafeBrowsingEnabled,

safe_browsing_opt_in != SAFE_BROWSING_OPT_OUT);

- prefs->SetBoolean(safe_browsing::GetExtendedReportingPrefName(),

- safe_browsing_opt_in == EXTENDED_REPORTING_OPT_IN);

+ safe_browsing::SetExtendedReportingPref(

+ prefs.get(), safe_browsing_opt_in == EXTENDED_REPORTING_OPT_IN);

if (incidents_sent)

prefs->Set(prefs::kSafeBrowsingIncidentsSent, *incidents_sent);

@@ -815,8 +815,7 @@ TEST_F(IncidentReportingServiceTest, NoUploadBeforeExtendedReporting) {

// Ensure that no report processing remains.

ASSERT_FALSE(instance_->IsProcessingReport());

- profile->GetPrefs()->SetBoolean(safe_browsing::GetExtendedReportingPrefName(),

- true);

+ safe_browsing::SetExtendedReportingPref(profile->GetPrefs(), true);

// Add a variation on the incident to the service.

instance_->GetIncidentReceiver()->AddIncidentForProfile(