chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 2435933003: Further refactoring of SBER1 preference usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 2435933003: Further refactoring of SBER1 preference usage. (Closed)

Patch Set: git cl format Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc » ('j') | components/safe_browsing_db/safe_browsing_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index bedcbbe85ea8e316f4f0ed0bdbf8960a34da2c6e..3beab5636a5ce3808c5ec574d402cef4ee565bb7 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -518,8 +518,7 @@ class DownloadProtectionServiceTest : public testing::Test {

}

void SetExtendedReportingPreference(bool is_extended_reporting) {

- profile_->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(),

- is_extended_reporting);

+ SetExtendedReportingPref(profile_->GetPrefs(), is_extended_reporting);

}

// Check scenarios where we should/shouldn't send a report for