Move tray code from ui/chromeos/network/

Move tray code from ui/chromeos/network/

Move remaining ui/chromeos/network code to to
ash/common/system/chromeos/network

This includes moving the associated resources to src/ash.

It also eliminates material_design_icon_controller.cc.

BUG=657127
Committed: https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f
Cr-Commit-Position: refs/heads/master@{#427166}

[stevenjb, 2016-10-20 00:02:42]

stevenjb@chromium.org changed reviewers:
+ jamescook@chromium.org

[stevenjb, 2016-10-20 00:02:43]

This one is mostly a straightforward move.

[James Cook, 2016-10-20 16:05:55]

LGTM with nits

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_icon.cc (right):

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_icon.cc:63: return
MaterialDesignController::GetMode() !=
I think this should be MaterialDesignController::UseMaterialDesignSystemIcons()
-- the MD guys are trying to have separate settings for things. For example,
right now system icons are "material experimental" only.

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_icon_animation.h (right):

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_icon_animation.h:22: class
UI_CHROMEOS_EXPORT NetworkIconAnimation : public gfx::AnimationDelegate {
no UI_CHROMEOS_EXPORT, here and throughout. You might need ASH_EXPORT, not sure.

[stevenjb, 2016-10-24 20:08:25]

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_icon.cc (right):

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_icon.cc:63: return
MaterialDesignController::GetMode() !=
On 2016/10/20 16:05:55, James Cook wrote:
> I think this should be
MaterialDesignController::UseMaterialDesignSystemIcons()
> -- the MD guys are trying to have separate settings for things. For example,
> right now system icons are "material experimental" only.
> 

Done.

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/network_icon_animation.h (right):

https://codereview.chromium.org/2435903002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/network_icon_animation.h:22: class
UI_CHROMEOS_EXPORT NetworkIconAnimation : public gfx::AnimationDelegate {
On 2016/10/20 16:05:55, James Cook wrote:
> no UI_CHROMEOS_EXPORT, here and throughout. You might need ASH_EXPORT, not
sure.

Done.

[stevenjb, 2016-10-24 20:08:34]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-10-24 20:08:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2435903002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-24 20:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:10:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-24 22:12:38]

Description was changed from

==========
Move tray code from ui/chromeos/network/

Move remaining ui/chromeos/network code to to
ash/common/system/chromeos/network

This includes moving the associated resources to src/ash.

It also eliminates material_design_icon_controller.cc.

BUG=657127
==========

to

==========
Move tray code from ui/chromeos/network/

Move remaining ui/chromeos/network code to to
ash/common/system/chromeos/network

This includes moving the associated resources to src/ash.

It also eliminates material_design_icon_controller.cc.

BUG=657127

Committed: https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f
Cr-Commit-Position: refs/heads/master@{#427166}
==========

[commit-bot: I haz the power, 2016-10-24 22:12:40]

Patchset 3 (id:??) landed as
https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f
Cr-Commit-Position: refs/heads/master@{#427166}

[Evan Stade, 2016-10-25 14:20:14]

estade@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-10-25 14:20:15]

thanks!