src/handles-inl.h - Issue 24359003: Only zapped used handles if a handle scope fits entirely within one handle block

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles-inl.h

Issue 24359003: Only zapped used handles if a handle scope fits entirely within one handle block (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/handles-inl.h

diff --git a/src/handles-inl.h b/src/handles-inl.h

index 5b879d8f088e2491669095c628586299f8781f20..6b1983b55b66618846659c4336e8a6d51e766403 100644

--- a/src/handles-inl.h

+++ b/src/handles-inl.h

@@ -130,16 +130,17 @@ void HandleScope::CloseScope(Isolate* isolate,

v8::ImplementationUtilities::HandleScopeData* current =

isolate->handle_scope_data();

- current->next = prev_next;

+ std::swap(current->next, prev_next);

Michael Starzinger 2013/09/27 11:24:30 nit: Two white-spaces after comma.

current->level--;

if (current->limit != prev_limit) {

current->limit = prev_limit;

DeleteExtensions(isolate);

- }

#ifdef ENABLE_EXTRA_CHECKS

- ZapRange(prev_next, prev_limit);

+ ZapRange(current->next, prev_limit);

+ } else {

+ ZapRange(current->next, prev_next);

#endif

+ }

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »