Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 24359003: Only zapped used handles if a handle scope fits entirely within one handle block (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Only zapped used handles if a handle scope fits entirely within one handle block This should avoid zapping the same unused handles over and over again when using many small nested handle scopes. BUG=none R=mstarzinger@chromium.org, vegorov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16987

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/handles-inl.h View 1 chunk +5 lines, -4 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-23 12:05:09 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/24359003/diff/1/src/handles-inl.h File src/handles-inl.h (right): https://codereview.chromium.org/24359003/diff/1/src/handles-inl.h#newcode133 src/handles-inl.h:133: std::swap(current->next, prev_next); nit: Two white-spaces after comma.
7 years, 2 months ago (2013-09-27 11:24:30 UTC) #2
jochen (gone - plz use gerrit)
7 years, 2 months ago (2013-09-27 11:31:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698