Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: logdog/common/storage/memory/memory_test.go

Issue 2435883002: LogDog: Fix archival Get/Tail implementations. (Closed)
Patch Set: LogDog: Fix archival Get/Tail implementations. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: logdog/common/storage/memory/memory_test.go
diff --git a/logdog/common/storage/memory/memory_test.go b/logdog/common/storage/memory/memory_test.go
index ea7bef4d4f6f7be9b8a8b0c2975828c8ab43c0df..40c746f04102bb40a191b73cb5f4b77182e6f56a 100644
--- a/logdog/common/storage/memory/memory_test.go
+++ b/logdog/common/storage/memory/memory_test.go
@@ -37,6 +37,14 @@ func index(recs []*rec) map[types.MessageIndex]int {
return index
}
+func mustGetIndex(e *storage.Entry) types.MessageIndex {
+ idx, err := e.GetStreamIndex()
+ if err != nil {
+ panic(err)
+ }
+ return idx
+}
+
func TestBigTable(t *testing.T) {
t.Parallel()
@@ -75,10 +83,10 @@ func TestBigTable(t *testing.T) {
}
var getRecs []*rec
- getAllCB := func(idx types.MessageIndex, data []byte) bool {
+ getAllCB := func(e *storage.Entry) bool {
getRecs = append(getRecs, &rec{
- index: idx,
- data: data,
+ index: mustGetIndex(e),
+ data: e.D,
})
return true
}
@@ -131,7 +139,7 @@ func TestBigTable(t *testing.T) {
Convey(`Will stop iterating if callback returns false.`, func() {
count := 0
- err := st.Get(req, func(types.MessageIndex, []byte) bool {
+ err := st.Get(req, func(*storage.Entry) bool {
count++
return false
})
@@ -160,25 +168,25 @@ func TestBigTable(t *testing.T) {
Convey(`Tail()`, func() {
Convey(`Can retrieve the tail record, 10.`, func() {
- d, idx, err := st.Tail(project, path)
+ e, err := st.Tail(project, path)
So(err, ShouldBeNil)
- So(d, ShouldResemble, numRec(10).data)
- So(idx, ShouldEqual, 10)
+ So(e.D, ShouldResemble, numRec(10).data)
+ So(mustGetIndex(e), ShouldEqual, 10)
})
Convey(`Will fail to retrieve records if the project doesn't exist.`, func() {
- _, _, err := st.Tail("project-does-not-exist", path)
+ _, err := st.Tail("project-does-not-exist", path)
So(err, ShouldEqual, storage.ErrDoesNotExist)
})
Convey(`Will fail to retrieve records if the path doesn't exist.`, func() {
- _, _, err := st.Tail(project, "testing/+/does/not/exist")
+ _, err := st.Tail(project, "testing/+/does/not/exist")
So(err, ShouldEqual, storage.ErrDoesNotExist)
})
Convey(`Will return an error if one is set.`, func() {
st.SetErr(errors.New("test error"))
- _, _, err := st.Tail("", "")
+ _, err := st.Tail("", "")
So(err, ShouldErrLike, "test error")
})
})

Powered by Google App Engine
This is Rietveld 408576698