Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: appengine/findit/util_scripts/crash_queries/crash_iterator.py

Issue 2435863003: [Findit] Add local git parsers. (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/util_scripts/crash_queries/crash_iterator.py
diff --git a/appengine/findit/util_scripts/crash_queries/crash_iterator.py b/appengine/findit/util_scripts/crash_queries/crash_iterator.py
index a55618a5a81b1f34e9de3ed609ee5f5eb9a6e170..930b6a5e3e2345de698c4399ec6eb97537fe0433 100644
--- a/appengine/findit/util_scripts/crash_queries/crash_iterator.py
+++ b/appengine/findit/util_scripts/crash_queries/crash_iterator.py
@@ -22,7 +22,8 @@ COMMON_CRASH_FIELDS = ['crashed_version', 'stack_trace', 'signature',
# TODO(katesonia): Switch to use fuction of objects encapsulating CrashClients,
# after the refactoring is done.
-def GetAnalysisClassForClient(client_id):
+# TODO(crbug.com/662540): Add unittests.
+def GetAnalysisClassForClient(client_id): # pragma: no cover.
if client_id == CrashClient.FRACAS:
return FracasCrashAnalysis
elif client_id == CrashClient.CRACAS:
@@ -34,8 +35,9 @@ def GetAnalysisClassForClient(client_id):
return None
+# TODO(crbug.com/662540): Add unittests.
def GetQueryForClient(client_id, property_values, start_date, end_date,
- datetime_pattern='%Y-%m-%d'):
+ datetime_pattern='%Y-%m-%d'): # pragma: no cover.
if property_values is None:
property_values = {}
@@ -51,6 +53,7 @@ def GetQueryForClient(client_id, property_values, start_date, end_date,
cls.requested_time < end_date)
+# TODO(crbug.com/662540): Add unittests.
def IterateCrashes(client_id,
app_id,
fields=None,
@@ -58,7 +61,7 @@ def IterateCrashes(client_id,
start_date=_A_YEAR_AGO,
end_date=_TODAY,
batch_size=_DEFAULT_BATCH_SIZE,
- batch_run=False):
+ batch_run=False): # pragma: no cover.
"""Genrates query to query crashes and iterates crashes.
Args:
« no previous file with comments | « appengine/findit/util_scripts/__init__.py ('k') | appengine/findit/util_scripts/crash_queries/delta_test/delta_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698