Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: appengine/findit/common/blame.py

Issue 2435863003: [Findit] Add local git parsers. (Closed)
Patch Set: Fix nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/common/change_log.py » ('j') | appengine/findit/common/change_log.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/common/blame.py
diff --git a/appengine/findit/common/blame.py b/appengine/findit/common/blame.py
index a44aa88107a9ed77f880dc32d60843018dbd54e7..3e562842599bc196ebda6ebe5cc29561b7e88bb1 100644
--- a/appengine/findit/common/blame.py
+++ b/appengine/findit/common/blame.py
@@ -6,7 +6,7 @@
class Region(object):
"""A region of some (unspecified) file at a (known) revision."""
def __init__(self, start, count, revision,
- author_name, author_email, author_time):
+ author_name=None, author_email=None, author_time=None):
self.start = start
self.count = count
self.revision = revision
@@ -27,8 +27,8 @@ class Region(object):
class Blame(list):
"""A list of regions for a (known) revision of a (known) file."""
- def __init__(self, revision, path):
- super(Blame, self).__init__()
+ def __init__(self, revision, path, regions=None):
+ super(Blame, self).__init__(regions or [])
stgao 2016/10/22 00:39:16 Can we just use the AddRegion below or remove AddR
Sharu Jiang 2016/10/25 00:36:19 This is removed in the newest patch.
self.revision = revision
self.path = path
« no previous file with comments | « no previous file | appengine/findit/common/change_log.py » ('j') | appengine/findit/common/change_log.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698