appengine/findit/common/blame.py - Issue 2435863003: [Findit] Add local git parsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/common/blame.py

Issue 2435863003: [Findit] Add local git parsers. (Closed)

Patch Set: Fix nits. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/common/blame.py

diff --git a/appengine/findit/common/blame.py b/appengine/findit/common/blame.py

index a44aa88107a9ed77f880dc32d60843018dbd54e7..60fc6759017f837ebc935de1f59b09f75e441bdd 100644

--- a/appengine/findit/common/blame.py

+++ b/appengine/findit/common/blame.py

@@ -6,7 +6,7 @@

class Region(object):

"""A region of some (unspecified) file at a (known) revision."""

def __init__(self, start, count, revision,

- author_name, author_email, author_time):

+ author_name=None, author_email=None, author_time=None):

stgao 2016/10/25 23:01:33 why default to None? An't they required? not avail

Sharu Jiang 2016/10/26 06:13:37 They are available for local checkout. This is jus

self.start = start

self.count = count

self.revision = revision