Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2419)

Unified Diff: runtime/vm/compiler.cc

Issue 243583008: Undo r35207 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/service/object.dart ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index afb0f99e938c3c1825b3292eafb7d7cddfdaec07..de4987a0b71dd5d190429553c7bf99e066052cd8 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -32,7 +32,6 @@
#include "vm/symbols.h"
#include "vm/tags.h"
#include "vm/timer.h"
-#include "vm/trace_buffer.h"
namespace dart {
@@ -605,13 +604,11 @@ static bool CompileParsedFunctionHelper(ParsedFunction* parsed_function,
// If the error isn't due to an out of range branch offset, we don't
// try again (done = true), and indicate that we did not finish
// compiling (is_compiled = false).
- const Error& bailout_error = Error::Handle(
- isolate->object_store()->sticky_error());
if (FLAG_trace_bailout) {
+ const Error& bailout_error = Error::Handle(
+ isolate->object_store()->sticky_error());
OS::Print("%s\n", bailout_error.ToErrorCString());
}
- function.log()->TraceF("Failed to compile optimized code: %s",
- bailout_error.ToErrorCString());
done = true;
ASSERT(optimized);
}
@@ -770,9 +767,6 @@ static RawError* CompileFunctionHelper(const Function& function,
per_compile_timer.Start();
ParsedFunction* parsed_function =
new ParsedFunction(Function::ZoneHandle(function.raw()));
- function.log()->TraceF("Compiled %s%s",
- (osr_id == Isolate::kNoDeoptId ? "" : "osr "),
- (optimized ? "optimized " : ""));
if (FLAG_trace_compiler) {
OS::Print("Compiling %s%sfunction: '%s' @ token %" Pd ", size %" Pd "\n",
(osr_id == Isolate::kNoDeoptId ? "" : "osr "),
@@ -791,7 +785,6 @@ static RawError* CompileFunctionHelper(const Function& function,
CompileParsedFunctionHelper(parsed_function, optimized, osr_id);
if (optimized && !success) {
// Optimizer bailed out. Disable optimizations and to never try again.
- function.log()->TraceF("Optimizations disabled");
if (FLAG_trace_compiler) {
OS::Print("--> disabling optimizations for '%s'\n",
function.ToFullyQualifiedCString());
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/service/object.dart ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698