Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243583005: Revert of [SyncFS] Post tasks between SyncEngine and SyncWorker (Closed)

Created:
6 years, 8 months ago by tzik
Modified:
6 years, 8 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of [SyncFS] Post tasks between SyncEngine and SyncWorker (https://codereview.chromium.org/236313009/) Reason for revert: This causes UAF on Linux ASan LSan Tests bot. The error log is: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1774 Original issue's description: > Remove all method-calls between SyncEngine and SyncWorker, > and make them to post tasks instead. > > BUG=347425 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264976 TBR=peria@chromium.org NOTREECHECKS=true NOTRY=true BUG=347425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -183 lines) Patch
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 7 chunks +27 lines, -96 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.h View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 13 chunks +32 lines, -47 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tzik
Created Revert of [SyncFS] Post tasks between SyncEngine and SyncWorker
6 years, 8 months ago (2014-04-21 11:33:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/243583005/1
6 years, 8 months ago (2014-04-21 11:33:54 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 11:34:18 UTC) #3
Message was sent while issue was closed. 
Change committed as 264980

Powered by Google App Engine
This is Rietveld 408576698