Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: test/cctest/asmjs/test-asm-typer.cc

Issue 2435823002: [V8][asm.js] Adds support to global const variables. (Closed)
Patch Set: Changes expected error messages in asm-typer cctest. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/asmjs/test-asm-typer.cc
diff --git a/test/cctest/asmjs/test-asm-typer.cc b/test/cctest/asmjs/test-asm-typer.cc
index 828a0cd12e3a2b7dd3bfcc28b6a7c5aeaf243779..31d01aa1669a88ffa8180dc5f419408dcda0073a 100644
--- a/test/cctest/asmjs/test-asm-typer.cc
+++ b/test/cctest/asmjs/test-asm-typer.cc
@@ -505,10 +505,10 @@ TEST(ErrorsInGlobalVariableDefinition) {
const char* error_message;
} kTests[] = {
{"var v;", "Global variable missing initializer"},
- {"var v = uninitialized;", "Invalid global variable initializer"},
+ {"var v = uninitialized;", "Undeclared identifier in global"},
{"var v = 'use asm';", "type annotation - forbidden literal"},
{"var v = 4294967296;", " - forbidden literal"},
- {"var v = not_fround;", "Invalid global variable initializer"},
+ {"var v = not_fround;", "initialize a global must be a const"},
bradnelson 2016/10/19 21:52:07 Add tests that hit: Undeclared identifier in retur
John 2016/10/20 15:13:22 Done.
{"var v = not_fround(1);", "expected call fround(literal)"},
{"var v = __fround__(1.0);", "expected call fround(literal)"},
{"var v = fround(1.0, 1.0);", "expected call fround(literal)"},

Powered by Google App Engine
This is Rietveld 408576698