Issue 2435773002: Make QuicTestClient no longer inherit from SimpleClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2435773002: Make QuicTestClient no longer inherit from SimpleClient (Closed)

Created:
4 years, 2 months ago by alyssar1

Modified:
4 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make QuicTestClient no longer inherit from SimpleClient Merge internal change: 136349092 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -67 lines)			Patch
	M	net/tools/quic/test_tools/quic_test_client.h	View		4 chunks	+56 lines, -42 lines	1 comment	Download
	M	net/tools/quic/test_tools/quic_test_client.cc	View		3 chunks	+1 line, -25 lines	0 comments	Download

Depends on Patchset:

Issue 2429173004 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

4 years, 2 months ago (2016-10-19 18:38:29 UTC) #2

lgtm

https://codereview.chromium.org/2435773002/diff/1/net/tools/quic/test_tools/q...
File net/tools/quic/test_tools/quic_test_client.h (left):

https://codereview.chromium.org/2435773002/diff/1/net/tools/quic/test_tools/q...
net/tools/quic/test_tools/quic_test_client.h:25: #include
"net/tools/quic/test_tools/simple_client.h"
Can you also remove this file? I believe it's no longer needed. (Yay!)

Expand Messages | Collapse Messages