Let SetEntropySource() fail if called after V8::Initialize().

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 79f4478ea6f626ff297314b4ed227d5dc088abed..0425d625f85d200974046a27e2afdf194fb24fc6 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4511,8 +4511,13 @@ class V8_EXPORT V8 {
   /**
    * Allows the host application to provide a callback which can be used
    * as a source of entropy for random number generators.
+   *
+   * \returns true if the entropy source was installed successfully, false
+   *   on failure.
+   * \note Setting an entropy source can only be done very early prior to
+   *   calling any other V8-related function.

[Dmitry Lomov (no reviews), 2013/09/23 11:24:15]

This is vague; the true statement is that SetEntropySource should be called
prior to V8::Intitialize.

Generally, we have a bunch of global parameter setters (V8::SetEntropySource,
V8::SetArrayBufferAllocator, V8::SetReturnAddressLocationResolver etc) that all
need to be called before V8::Initialize, but crucially do not depend on each
other (otherwise it will be a nightmare to call correctly)

[Benedikt Meurer, 2013/09/23 11:36:41]

Done.

    */
-  static void SetEntropySource(EntropySource source);
+  static bool SetEntropySource(EntropySource source);
 
   /**
    * Allows the host application to provide a callback that allows v8 to