Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_single.js

Issue 2435683003: Cleanup desktop NTP metrics recording, part 2 (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_ipc_router_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/local_ntp/most_visited_single.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_single.js b/chrome/browser/resources/local_ntp/most_visited_single.js
index 10ad3df65a6e1fac99db72b52cef2575e3ed1976..f08b0cec42c63fb7351c48869216e1c8d4379b95 100644
--- a/chrome/browser/resources/local_ntp/most_visited_single.js
+++ b/chrome/browser/resources/local_ntp/most_visited_single.js
@@ -16,10 +16,6 @@
* @const
*/
var LOG_TYPE = {
- // A suggestion coming from the server was rendered.
- NTP_SERVER_SIDE_SUGGESTION: 0,
- // A suggestion coming from the client was rendered.
- NTP_CLIENT_SIDE_SUGGESTION: 1,
// All NTP Tiles have finished loading (successfully or failing).
NTP_ALL_TILES_LOADED: 11,
};
@@ -310,7 +306,6 @@ var addTile = function(args) {
data.faviconUrl = 'chrome-search://favicon/size/16@' +
window.devicePixelRatio + 'x/' + data.renderViewId + '/' + data.tid;
}
- logEvent(LOG_TYPE.NTP_CLIENT_SIDE_SUGGESTION);
tiles.appendChild(renderTile(data));
} else if (args.url) {
// If a URL is passed: a server-side suggestion.
@@ -319,7 +314,6 @@ var addTile = function(args) {
if (/^javascript:/i.test(args.url) ||
/^javascript:/i.test(args.thumbnailUrl))
return;
- logEvent(LOG_TYPE.NTP_SERVER_SIDE_SUGGESTION);
tiles.appendChild(renderTile(args));
} else { // an empty tile
tiles.appendChild(renderTile(null));
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_ipc_router_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698