Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: media/base/audio_discard_helper.h

Issue 2435603009: Use ffmpeg for opus decoding, no need to maintain our decoder. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_discard_helper.h
diff --git a/media/base/audio_discard_helper.h b/media/base/audio_discard_helper.h
index 544c4cfa2e28232ffa59de45856980c7a19c723e..c96bf7abcc426dc1b453ec1d17a421d74de67655 100644
--- a/media/base/audio_discard_helper.h
+++ b/media/base/audio_discard_helper.h
@@ -34,7 +34,9 @@ class MEDIA_EXPORT AudioDiscardHelper {
// corresponding to the first encoded buffer is output. These frames are not
// represented in the encoded data stream and instead are an artifact of how
// most MP3 decoders work. See http://lame.sourceforge.net/tech-FAQ.txt
- AudioDiscardHelper(int sample_rate, size_t decoder_delay);
+ AudioDiscardHelper(int sample_rate,
+ size_t decoder_delay,
+ bool delayed_discard);
~AudioDiscardHelper();
// Converts a TimeDelta to a frame count based on the constructed sample rate.
@@ -92,7 +94,7 @@ class MEDIA_EXPORT AudioDiscardHelper {
// decoded buffer. In this case DiscardPadding must be carried over from the
// previous encoded buffer. Enabled automatically if an encoded buffer is
wolenetz 2016/10/21 22:30:58 It's const, ctor initialized now, so no longer ena
wolenetz 2016/11/18 00:36:41 In patch set 2, this code comment still incorrectl
DaleCurtis 2016/11/18 00:51:27 Fixed.
// given to ProcessBuffers() with a NULL decoded buffer.
- bool delayed_discard_;
+ const bool delayed_discard_;
DecoderBuffer::DiscardPadding delayed_discard_padding_;
// When |decoder_delay_| > 0, the number of frames which should be discarded

Powered by Google App Engine
This is Rietveld 408576698