Cleanup unused methods and return values in FWL code.

xfa/fxgraphics/cfx_graphics.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxgraphics/cfx_graphics.h"
 
 #include <memory>
 
@@ skipping 936 matching lines @@
 }
 
 FWL_Error CFX_Graphics::ShowText(const CFX_PointF& point,
                                  const CFX_WideString& text,
                                  CFX_Matrix* matrix) {
   if (m_type == FX_CONTEXT_Device && m_renderDevice)
     return RenderDeviceShowText(point, text, matrix);
   return FWL_Error::PropertyInvalid;
 }
 
-FWL_Error CFX_Graphics::CalcTextRect(CFX_RectF& rect,
-                                     const CFX_WideString& text,
-                                     FX_BOOL isMultiline,
-                                     CFX_Matrix* matrix) {
-  if (m_type == FX_CONTEXT_Device && m_renderDevice) {
-    int32_t length = text.GetLength();
-    uint32_t* charCodes = FX_Alloc(uint32_t, length);
-    FXTEXT_CHARPOS* charPos = FX_Alloc(FXTEXT_CHARPOS, length);
-    CalcTextInfo(text, charCodes, charPos, rect);
-    FX_Free(charPos);
-    FX_Free(charCodes);
-    return FWL_Error::Succeeded;
-  }
-  return FWL_Error::PropertyInvalid;
+void CFX_Graphics::CalcTextRect(CFX_RectF& rect,
+                                const CFX_WideString& text,
+                                FX_BOOL isMultiline,
+                                CFX_Matrix* matrix) {
+  if (m_type != FX_CONTEXT_Device || !m_renderDevice)
+    return;
+
+  int32_t length = text.GetLength();
+  uint32_t* charCodes = FX_Alloc(uint32_t, length);
+  FXTEXT_CHARPOS* charPos = FX_Alloc(FXTEXT_CHARPOS, length);
+  CalcTextInfo(text, charCodes, charPos, rect);
+  FX_Free(charPos);
+  FX_Free(charCodes);
 }
 
 FWL_Error CFX_Graphics::Transfer(CFX_Graphics* graphics,
                                  const CFX_Matrix* matrix) {
   if (!graphics || !graphics->m_renderDevice)
     return FWL_Error::ParameterInvalid;
   CFX_Matrix m;
   m.Set(m_info.CTM.a, m_info.CTM.b, m_info.CTM.c, m_info.CTM.d, m_info.CTM.e,
         m_info.CTM.f);
   if (matrix) {
@@ skipping 589 matching lines @@
   CTM = other.CTM;
   isActOnDash = other.isActOnDash;
   strokeColor = other.strokeColor;
   fillColor = other.fillColor;
   font = other.font;
   fontSize = other.fontSize;
   fontHScale = other.fontHScale;
   fontSpacing = other.fontSpacing;
   return *this;
 }