Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2435603002: [WeakMemoryCache] Remove dead/live distinction of Resource outside core/fetch (Closed)

Created:
4 years, 2 months ago by hiroshige
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, extensions-reviews_chromium.org, kinuko+watch, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WeakMemoryCache] Remove dead/live distinction of Resource outside core/fetch After https://codereview.chromium.org/2411243004/, dead capacities and distinction between total/dead/live sizes are no longer meaningful. BUG=603462 Committed: https://crrev.com/be1252e8ca2f4a59cc19f06c61fb795b56f31e8c Cr-Commit-Position: refs/heads/master@{#435329}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase, rename capacities to capacity #

Total comments: 4

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -224 lines) Patch
M chrome/browser/extensions/api/processes/processes_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 2 3 4 5 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 4 5 1 chunk +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/task_manager/task_manager_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 5 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/common/resource_usage_reporter_type_converters.cc View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_thread_observer.cc View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M components/web_cache/browser/web_cache_manager.h View 1 2 3 4 5 5 chunks +6 lines, -27 lines 0 comments Download
M components/web_cache/browser/web_cache_manager.cc View 1 2 3 4 6 chunks +31 lines, -83 lines 0 comments Download
M components/web_cache/browser/web_cache_manager_unittest.cc View 1 12 chunks +25 lines, -55 lines 0 comments Download
M components/web_cache/public/interfaces/web_cache.mojom View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M components/web_cache/renderer/web_cache_impl.h View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M components/web_cache/renderer/web_cache_impl.cc View 1 2 3 4 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebCache.cpp View 1 2 3 4 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebCache.h View 1 2 3 4 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 37 (29 generated)
bashi
(drive-by) https://codereview.chromium.org/2435603002/diff/70001/components/web_cache/browser/web_cache_manager.cc File components/web_cache/browser/web_cache_manager.cc (left): https://codereview.chromium.org/2435603002/diff/70001/components/web_cache/browser/web_cache_manager.cc#oldcode397 components/web_cache/browser/web_cache_manager.cc:397: UMA_HISTOGRAM_MEMORY_MB("Cache.ActiveDeadSizeMB", nit: Shouldn't we deprecate this metric in ...
4 years ago (2016-11-25 07:04:35 UTC) #17
hiroshige
https://codereview.chromium.org/2435603002/diff/70001/components/web_cache/browser/web_cache_manager.cc File components/web_cache/browser/web_cache_manager.cc (left): https://codereview.chromium.org/2435603002/diff/70001/components/web_cache/browser/web_cache_manager.cc#oldcode397 components/web_cache/browser/web_cache_manager.cc:397: UMA_HISTOGRAM_MEMORY_MB("Cache.ActiveDeadSizeMB", On 2016/11/25 07:04:35, bashi1 wrote: > nit: Shouldn't ...
4 years ago (2016-11-25 09:03:20 UTC) #18
hiroshige
PTAL, mkwst@chromium.org as a ipc/SECURITY_OWNER for the following files: - chrome/common/render_messages.h - chrome/common/resource_usage_reporter_type_converters.cc - components/web_cache/public/interfaces/web_cache.mojom ...
4 years ago (2016-11-30 07:31:11 UTC) #24
Mike West
Dropping bits from IPC and mojom LGTM.
4 years ago (2016-11-30 09:38:35 UTC) #25
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-30 15:32:22 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435603002/90001
4 years ago (2016-11-30 17:56:43 UTC) #32
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years ago (2016-11-30 18:03:09 UTC) #35
commit-bot: I haz the power
4 years ago (2016-11-30 18:05:31 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/be1252e8ca2f4a59cc19f06c61fb795b56f31e8c
Cr-Commit-Position: refs/heads/master@{#435329}

Powered by Google App Engine
This is Rietveld 408576698