Simplify the MediaGalleriesPlatformAppBrowserTest copyTo tests.

Simplify the MediaGalleriesPlatformAppBrowserTest copyTo tests.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225393

[tommycli, 2013-09-24 20:13:22]

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
File
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/copy_to_common.js
(right):

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/copy_to_common.js:5:
function onWriteEnd(testImageFileEntry, gallery, filename, expectSucceed) {
Call this 'testCopyTo' or something, and probably move down so that the test
flows from top to bottom.

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/copy_to_common.js:21:
var validWEBPImageCase = {
Not in this CL, but maybe we can leverage your test.jpg here also.

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
File
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/test.js
(right):

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/test.js:9:
runCopyToTest(validWEBPImageCase, false);
false /* expectSucceed */ and in other places

[Lei Zhang, 2013-09-24 20:56:37]

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
File
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/copy_to_common.js
(right):

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/copy_to_common.js:5:
function onWriteEnd(testImageFileEntry, gallery, filename, expectSucceed) {
On 2013/09/24 20:13:22, tommycli wrote:
> Call this 'testCopyTo' or something, and probably move down so that the test
> flows from top to bottom.

Done.

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/copy_to_common.js:21:
var validWEBPImageCase = {
On 2013/09/24 20:13:22, tommycli wrote:
> Not in this CL, but maybe we can leverage your test.jpg here also.

Added a TODO.

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
File
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/test.js
(right):

https://codereview.chromium.org/24356005/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/media_galleries/copy_to_access/no_access/test.js:9:
runCopyToTest(validWEBPImageCase, false);
On 2013/09/24 20:13:22, tommycli wrote:
> false /* expectSucceed */ and in other places

Done.

[Lei Zhang, 2013-09-24 22:40:11]

Patch set 3 puts things in top-down order.

[tommycli, 2013-09-24 23:08:18]

awesome lgtm

[commit-bot: I haz the power, 2013-09-24 23:11:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24356005/9001

[commit-bot: I haz the power, 2013-09-25 02:09:32]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-09-25 02:58:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24356005/9001

[commit-bot: I haz the power, 2013-09-25 05:48:27]

Retried try job too often on linux_chromeos for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-25 19:35:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24356005/9001

[commit-bot: I haz the power, 2013-09-25 21:43:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24356005/9001

[commit-bot: I haz the power, 2013-09-26 08:22:19]

Change committed as 225393