|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by hongchan Modified:
4 years ago Reviewers:
Raymond Toy CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionThe sample result from |audit.html| unit test:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute 'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0 present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to [1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6. assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size 0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of {"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal [0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of {"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true: expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
Committed: https://crrev.com/c06bb6dbd09d88d8d2e8ecda9e9a016d9b3dfe40
Cr-Commit-Position: refs/heads/master@{#435150}
Patch Set 1 #Patch Set 2 : New WebAudio layout test utility: audit.js #Patch Set 3 : Improving test outputs #Patch Set 4 : more progress #
Total comments: 44
Patch Set 5 : Addressing feedback from rtoy@ #Patch Set 6 : Ready for review #Patch Set 7 : Fixing nits after l-g-t-m #
Messages
Total messages: 39 (22 generated)
Description was changed from ========== New WebAudio layout testing utility: audit.js [DO NOT SUBMIT] BUG= ========== to ========== [DO NOT SUBMIT] Please try this out and review the CL in small chunks. TODOs: - Expand report() method to provide the detail summary of the task. - Add the buffer factory. - Flesh out "the fail detail" message for the assertions. BUG= TEST= LayoutTests/webaudio/unit-tests/audit.html ==========
hongchan@chromium.org changed reviewers: + rtoy@chromium.org
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
TODOs:
- Expand report() method to provide the detail summary of the task.
- Add the buffer factory.
- Flesh out "the fail detail" message for the assertions.
BUG=
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
TODOs:
- Expand report() method to provide the detail summary of the task.
- Add the buffer factory.
- Flesh out "the fail detail" message for the assertions.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> TASK STARTED : [basic] Simple unit tests for basic assertions.
PASS [.] "OfflineAudioContext()" does exist.
PASS [.] "var foo = 0;" did not throw an exception as expected.
PASS [.] "var foo = bar;" threw "ReferenceError"(string) : "bar is not
defined".
PASS [.] "String()" did not throw an exception as expected.
PASS [.] "true"(boolean) is true(boolean).
PASS [.] "false"(boolean) is false(boolean).
PASS [.] "true"(boolean) is true(boolean).
PASS [.] "3"(number) is not NaN.
PASS [.] "Object"(object) is not NaN. (non-Number or non-Array)
PASS [.] "[1,2,3]"(object::array) does not contain NaN.
PASS [.] "1"(number) is equal to "1"(number).
PASS [.] "1"(number) is not equal to "2"(number).
PASS [.] "object"(string) is equal to "object"(string).
PASS [.] "2"(number) is greater than "1"(number).
PASS [.] "2"(number) is greater than or equal to "2"(number).
PASS [.] "1"(number) is less than "2"(number).
PASS [.] "1"(number) is less than or equal to "1"(number).
PASS << TASK FINISHED: [basic] All assertion passed. (total 17 assertions)
PASS >> TASK STARTED : [numerical] Numerical assertion unit test.
PASS [.] "2.3"(number) is "2"(number) within an error of "0.3"(number)
PASS [.] "[1,1,1]"(object::array) contains only the constant "1"(number).
FAIL [X] "[1,8,11,18,6,5,5,5,123,49]"(object::array) contains 7 values that
are *NOT* equal to "5"(number): <0:1> <1:8> <2:11> <3:18> <4:6> and 2 more
errors. assert_true: expected true got false
PASS [.] "[1,1,1]"(object::array) is identical to the array
"[1,1,1]"(object::array).
FAIL [X] "[1,8,11,18,6,5,5,5,123,49]"(object::array) contains 3 values that
are *NOT* equal to "[1,8,10,18,6,5,6,5,123,48]"(object::array): <2:11 != 10>
<6:5 != 6> <9:49 != 48> assert_true: expected true got false
PASS [.] "[1,1,1,1,2,2,3,3,3]"(object::array) contains all the expected
values in the correct order: "[1,2,3]"(object::array).
FAIL [X] "[1,1,1,1,2,2,3,3,3]"(object::array) contains an unexpected value of
3 at index 6. assert_true: expected true got false
PASS [.] "[0.5,0.5,0.55,0.5,0.45,0.5]"(object::array) has no glitch above the
threshold of "0.06"(number).
FAIL [X] "[0.5,0.5,0.55,0.5,0.45,0.5]"(object::array) has a glitch at index 5
of size "0.04999999999999999"(number). assert_true: expected true got false
PASS [.] "[0.11,0.19]"(object::array) equals "[0.1,0.2]"(object::array) with
an element-wise tolerance of {"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << TASK FINISHED: [numerical] 4 out of 10 assertions were failed.
assert_true: expected true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
PTAL. I think the patch reached the point where the preliminary review is possible. Early feedback and iteration would be helpful!
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
TODOs:
- Expand report() method to provide the detail summary of the task.
- Add the buffer factory.
- Flesh out "the fail detail" message for the assertions.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> TASK STARTED : [basic] Simple unit tests for basic assertions.
PASS [.] "OfflineAudioContext()" does exist.
PASS [.] "var foo = 0;" did not throw an exception as expected.
PASS [.] "var foo = bar;" threw "ReferenceError"(string) : "bar is not
defined".
PASS [.] "String()" did not throw an exception as expected.
PASS [.] "true"(boolean) is true(boolean).
PASS [.] "false"(boolean) is false(boolean).
PASS [.] "true"(boolean) is true(boolean).
PASS [.] "3"(number) is not NaN.
PASS [.] "Object"(object) is not NaN. (non-Number or non-Array)
PASS [.] "[1,2,3]"(object::array) does not contain NaN.
PASS [.] "1"(number) is equal to "1"(number).
PASS [.] "1"(number) is not equal to "2"(number).
PASS [.] "object"(string) is equal to "object"(string).
PASS [.] "2"(number) is greater than "1"(number).
PASS [.] "2"(number) is greater than or equal to "2"(number).
PASS [.] "1"(number) is less than "2"(number).
PASS [.] "1"(number) is less than or equal to "1"(number).
PASS << TASK FINISHED: [basic] All assertion passed. (total 17 assertions)
PASS >> TASK STARTED : [numerical] Numerical assertion unit test.
PASS [.] "2.3"(number) is "2"(number) within an error of "0.3"(number)
PASS [.] "[1,1,1]"(object::array) contains only the constant "1"(number).
FAIL [X] "[1,8,11,18,6,5,5,5,123,49]"(object::array) contains 7 values that
are *NOT* equal to "5"(number): <0:1> <1:8> <2:11> <3:18> <4:6> and 2 more
errors. assert_true: expected true got false
PASS [.] "[1,1,1]"(object::array) is identical to the array
"[1,1,1]"(object::array).
FAIL [X] "[1,8,11,18,6,5,5,5,123,49]"(object::array) contains 3 values that
are *NOT* equal to "[1,8,10,18,6,5,6,5,123,48]"(object::array): <2:11 != 10>
<6:5 != 6> <9:49 != 48> assert_true: expected true got false
PASS [.] "[1,1,1,1,2,2,3,3,3]"(object::array) contains all the expected
values in the correct order: "[1,2,3]"(object::array).
FAIL [X] "[1,1,1,1,2,2,3,3,3]"(object::array) contains an unexpected value of
3 at index 6. assert_true: expected true got false
PASS [.] "[0.5,0.5,0.55,0.5,0.45,0.5]"(object::array) has no glitch above the
threshold of "0.06"(number).
FAIL [X] "[0.5,0.5,0.55,0.5,0.45,0.5]"(object::array) has a glitch at index 5
of size "0.04999999999999999"(number). assert_true: expected true got false
PASS [.] "[0.11,0.19]"(object::array) equals "[0.1,0.2]"(object::array) with
an element-wise tolerance of {"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << TASK FINISHED: [numerical] 4 out of 10 assertions were failed.
assert_true: expected true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
TODOs:
- Expand report() method to provide the detail summary of the task.
- Add the buffer factory.
- Flesh out "the fail detail" message for the assertions.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> [basic] Simple unit tests for basic assertions.
PASS . OfflineAudioContext does exist.
PASS . Setting foo to 0 did not throw an exception as expected.
PASS . function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS . true is true.
PASS . false is false.
PASS . 3 is not NaN.
PASS . A newly created object is not NaN. (non-Number or non-Array)
PASS . [1,2,3] does not contain NaN.
FAIL X [1,2,3,NaN,4,5,6,NaN] contains 2 NaNs at the index of (3,7) assert_true:
expected true got false
PASS . 1 is equal to 1.
PASS . 1 is not equal to 2.
PASS . object is equal to object.
PASS . 2 is greater than 1.
PASS . 2 is greater than or equal to 2.
PASS . 1 is less than 2.
PASS . 1 is less than or equal to 1.
FAIL << [basic] 1 out of 16 assertions were failed. assert_true: expected true
got false
PASS >> [numerical] Numerical assertion unit test.
PASS . 2.3 is 2 within an error of 0.3
PASS . [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
<0:1> <1:8> <2:11> <3:18> <4:6> and 2 more errors. assert_true: expected true
got false
PASS . [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]: <2:11 != 10> <6:5 != 6> <9:49 != 48> assert_true:
expected true got false
PASS . [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: [1,2,3].
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS . [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
PASS . [0.11,0.19] equals [0.1,0.2] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << [numerical] 4 out of 10 assertions were failed. assert_true: expected
true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
On 2016/10/20 22:37:02, hongchan wrote: > PTAL. > > I think the patch reached the point where the preliminary review is possible. > Early feedback and iteration would be helpful! The CL is not ready for the final review, but it's better to discuss on the progress via the review tool.
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
TODOs:
- Expand report() method to provide the detail summary of the task.
- Add the buffer factory.
- Flesh out "the fail detail" message for the assertions.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> [basic] Simple unit tests for basic assertions.
PASS . OfflineAudioContext does exist.
PASS . Setting foo to 0 did not throw an exception as expected.
PASS . function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS . true is true.
PASS . false is false.
PASS . 3 is not NaN.
PASS . A newly created object is not NaN. (non-Number or non-Array)
PASS . [1,2,3] does not contain NaN.
FAIL X [1,2,3,NaN,4,5,6,NaN] contains 2 NaNs at the index of (3,7) assert_true:
expected true got false
PASS . 1 is equal to 1.
PASS . 1 is not equal to 2.
PASS . object is equal to object.
PASS . 2 is greater than 1.
PASS . 2 is greater than or equal to 2.
PASS . 1 is less than 2.
PASS . 1 is less than or equal to 1.
FAIL << [basic] 1 out of 16 assertions were failed. assert_true: expected true
got false
PASS >> [numerical] Numerical assertion unit test.
PASS . 2.3 is 2 within an error of 0.3
PASS . [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
<0:1> <1:8> <2:11> <3:18> <4:6> and 2 more errors. assert_true: expected true
got false
PASS . [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]: <2:11 != 10> <6:5 != 6> <9:49 != 48> assert_true:
expected true got false
PASS . [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: [1,2,3].
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS . [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
PASS . [0.11,0.19] equals [0.1,0.2] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << [numerical] 4 out of 10 assertions were failed. assert_true: expected
true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> [basic] Simple unit tests for basic assertions.
PASS . OfflineAudioContext does exist.
PASS . Setting foo to 0 did not throw an exception as expected.
PASS . function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS . true is true.
PASS . false is false.
PASS . 3 is not NaN.
PASS . A newly created object is not NaN. (non-Number or non-Array)
PASS . [1,2,3] does not contain NaN.
FAIL X [1,2,3,NaN,4,5,6,NaN] contains 2 NaNs at the index of (3,7) assert_true:
expected true got false
PASS . 1 is equal to 1.
PASS . 1 is not equal to 2.
PASS . object is equal to object.
PASS . 2 is greater than 1.
PASS . 2 is greater than or equal to 2.
PASS . 1 is less than 2.
PASS . 1 is less than or equal to 1.
FAIL << [basic] 1 out of 16 assertions were failed. assert_true: expected true
got false
PASS >> [numerical] Numerical assertion unit test.
PASS . 2.3 is 2 within an error of 0.3
PASS . [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
<0:1> <1:8> <2:11> <3:18> <4:6> and 2 more errors. assert_true: expected true
got false
PASS . [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]: <2:11 != 10> <6:5 != 6> <9:49 != 48> assert_true:
expected true got false
PASS . [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: [1,2,3].
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS . [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
PASS . [0.11,0.19] equals [0.1,0.2] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << [numerical] 4 out of 10 assertions were failed. assert_true: expected
true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> [basic] Simple unit tests for basic assertions.
PASS . OfflineAudioContext does exist.
PASS . Setting foo to 0 did not throw an exception as expected.
PASS . function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS . true is true.
PASS . false is false.
PASS . 3 is not NaN.
PASS . A newly created object is not NaN. (non-Number or non-Array)
PASS . [1,2,3] does not contain NaN.
FAIL X [1,2,3,NaN,4,5,6,NaN] contains 2 NaNs at the index of (3,7) assert_true:
expected true got false
PASS . 1 is equal to 1.
PASS . 1 is not equal to 2.
PASS . object is equal to object.
PASS . 2 is greater than 1.
PASS . 2 is greater than or equal to 2.
PASS . 1 is less than 2.
PASS . 1 is less than or equal to 1.
FAIL << [basic] 1 out of 16 assertions were failed. assert_true: expected true
got false
PASS >> [numerical] Numerical assertion unit test.
PASS . 2.3 is 2 within an error of 0.3
PASS . [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
<0:1> <1:8> <2:11> <3:18> <4:6> and 2 more errors. assert_true: expected true
got false
PASS . [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]: <2:11 != 10> <6:5 != 6> <9:49 != 48> assert_true:
expected true got false
PASS . [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: [1,2,3].
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS . [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
PASS . [0.11,0.19] equals [0.1,0.2] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << [numerical] 4 out of 10 assertions were failed. assert_true: expected
true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception as expected.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS true is true.
PASS false is false.
PASS 3 is not NaN.
PASS A newly created object is not NaN. (non-Number or non-Array)
PASS [1,2,3] does not contain NaN.
FAIL X [1,2,3,NaN,4,5,6,NaN] contains 2 NaNs at the index of (3,7) assert_true:
expected true got false
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS [object Promise] rejected correctly with "TypeError: Failed to execute
'decodeAudioData' on 'AudioContext': 1 argument required, but only 0 present.".
PASS Start OAC rendering resolved correctly.
FAIL << [basic] 1 out of 18 assertions were failed. assert_true: expected true
got false
PASS >> [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
<0:1> <1:8> <2:11> <3:18> <4:6> and 2 more errors. assert_true: expected true
got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]: <2:11 != 10> <6:5 != 6> <9:49 != 48> assert_true:
expected true got false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: [1,2,3].
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
PASS [0.11,0.19] equals [0.1,0.2] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << [numerical] 4 out of 10 assertions were failed. assert_true: expected
true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:24: if (!self.hasOwnProperty(testharnessProperties[name])) { From our BaseAudioContext experience, do we want hasOwnProperty here? https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:31: // TODO(hongchan): is this something we want? Do we really need this? I think we should let testharness and the browser do what ever it wants. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:75: // or Float32Array). Returns a result with indices of NaN. Update comment because it returns for an indices. (Is that a Javascript object type? Maybe you want to say it's an array.) https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:76: function _isOrHasNaN (target) { isOrHasNan? I misread this at first as missing some word. But you're really saying target is a NaN or has as NaN. How about just isNaNOrContainsNaN. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:85: } else if (target instanceof Float32Array || target instanceof Array) { Should we support Float64Array too? https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:111: // TODO(hongchan): this might not be needed. You're using this, so it's needed right? https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:130: // } else { This should be removed. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:135: // let elements = targetString.split(' '); This should be removed. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:157: * with a assertion subtask. "a assertion" -> "an assertion" Not really clear what an "assertion subtask" means here. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:291: didThrow = false; Why false? This did throw, right? If it didn't, then failDetail below is also wrong. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:495: if (++counter >= 5) { Probably want 5 to be settable by the test. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:622: + 'element-wise tolerance of ' + maxAllowedErrorDetail + '.'; This seems a regression from the old Audit that printed out lots of data on the failures. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:629: * Check if |actual| array contains a set of |expected| values in a certain Need to expand on this to explain what "certain order" really means. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:658: * Check if |actual| array does not have any glitches. Note that |threshold| Needs more detailed explanation of what "glitch" means. Didn't we have a more detailed comment from Audit? https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:817: // Start running all the tasks scheduled. Probably want to describe the optional args to run() here. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html:74: Need test where this fails. To be thorough, need to try different option values, with and without some threshold, or as a simple number.
Thanks for the review! I'll address the comments soon. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:24: if (!self.hasOwnProperty(testharnessProperties[name])) { On 2016/11/08 21:14:18, Raymond Toy wrote: > From our BaseAudioContext experience, do we want hasOwnProperty here? |self| is the global scope, so there is no inheritance going on here this level. I think this is okay and how it should work. (because testharness.js only works on the main global scope.) https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:31: // TODO(hongchan): is this something we want? On 2016/11/08 21:14:18, Raymond Toy wrote: > Do we really need this? I think we should let testharness and the browser do > what ever it wants. For my use case, this significantly improves the readability of the test result. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:75: // or Float32Array). Returns a result with indices of NaN. On 2016/11/08 21:14:18, Raymond Toy wrote: > Update comment because it returns for an indices. (Is that a Javascript object > type? Maybe you want to say it's an array.) This method is confusing. I thought it's clever to detect a NaN or NaNs in an array, but both the result and the intention are confusing. (Just like you misread the name...) https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:76: function _isOrHasNaN (target) { On 2016/11/08 21:14:18, Raymond Toy wrote: > isOrHasNan? I misread this at first as missing some word. But you're really > saying target is a NaN or has as NaN. How about just isNaNOrContainsNaN. Acknowledged. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:111: // TODO(hongchan): this might not be needed. On 2016/11/08 21:14:18, Raymond Toy wrote: > You're using this, so it's needed right? This needs more work. There are some stuffs that can be salvaged. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:130: // } else { On 2016/11/08 21:14:18, Raymond Toy wrote: > This should be removed. I am still deciding on this. We need some method to assemble a string out of array or object. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:135: // let elements = targetString.split(' '); On 2016/11/08 21:14:18, Raymond Toy wrote: > This should be removed. Noted. I will sit on this few more days. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:157: * with a assertion subtask. On 2016/11/08 21:14:18, Raymond Toy wrote: > "a assertion" -> "an assertion" > > Not really clear what an "assertion subtask" means here. This one is also a bare bone design of the summary report. It seems like it's not really necessary after introducing 'actual description' in should(). https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:291: didThrow = false; On 2016/11/08 21:14:18, Raymond Toy wrote: > Why false? This did throw, right? If it didn't, then failDetail below is also > wrong. I should rename the variable to |passed|. The third else clause handles the case where it throws but with a wrong error type. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:495: if (++counter >= 5) { On 2016/11/08 21:14:18, Raymond Toy wrote: > Probably want 5 to be settable by the test. The assertion configuration is another matter. It needs a whiteboard discussion. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:622: + 'element-wise tolerance of ' + maxAllowedErrorDetail + '.'; On 2016/11/08 21:14:18, Raymond Toy wrote: > This seems a regression from the old Audit that printed out lots of data on the > failures. beCloseToArray() was an overloaded beast. What type of information do you need more here? https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:629: * Check if |actual| array contains a set of |expected| values in a certain On 2016/11/08 21:14:18, Raymond Toy wrote: > Need to expand on this to explain what "certain order" really means. Perhaps a 'user-defined' order? https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:658: * Check if |actual| array does not have any glitches. Note that |threshold| On 2016/11/08 21:14:18, Raymond Toy wrote: > Needs more detailed explanation of what "glitch" means. Didn't we have a more > detailed comment from Audit? Nope. The comments are same. I didn't use the example though - because the syntax has been changed. 1) Examples in the comment. 2) Live examples in the unit test HTML. Which one do you prefer? https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:817: // Start running all the tasks scheduled. On 2016/11/08 21:14:18, Raymond Toy wrote: > Probably want to describe the optional args to run() here. It's being properly handled. See the if statement below.
https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:622: + 'element-wise tolerance of ' + maxAllowedErrorDetail + '.'; On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > This seems a regression from the old Audit that printed out lots of data on > the > > failures. > > beCloseToArray() was an overloaded beast. What type of information do you need > more here? Recall we used to print out a short summary and a verbose output (because verbose was the default). The verbose output included something like Index Actual Expected Diff RelError 1 1 2 1 0.5 2 2 3 1 0.3333 Max diff of ddddd at index kkkk Max relError of rrrrr at index nnnnn. Super useful when thresholds depend on the platform so you can use trybots to get the appropriate thresholds. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:629: * Check if |actual| array contains a set of |expected| values in a certain On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > Need to expand on this to explain what "certain order" really means. > > Perhaps a 'user-defined' order? Yes, that's much clearer. Or just say the array contains only the values in |expected| in the order of values in |expected|. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:658: * Check if |actual| array does not have any glitches. Note that |threshold| On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > Needs more detailed explanation of what "glitch" means. Didn't we have a more > > detailed comment from Audit? > > Nope. The comments are same. I didn't use the example though - because the > syntax has been changed. > > 1) Examples in the comment. > 2) Live examples in the unit test HTML. > > Which one do you prefer? Prefer 1 because it's easier to find; I won't be looking at the unit-test html when trying to figure this out. If the example it too long, then reference the unit-test html, I guess. (Or both). And maybe at the top of this file add a reference to the unit-test file. I think this also means the unit-test file should exercise all possible options for every single method here. Is there a way to mark a test as expected to fail? That would be really useful. (I suspect testharness doesn't allow that.)
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS ## AUDIT TASK RUNNER STARTED.
PASS >> [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception as expected.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS true is true.
PASS false is false.
PASS 3 is not NaN.
PASS A newly created object is not NaN. (non-Number or non-Array)
PASS [1,2,3] does not contain NaN.
FAIL X [1,2,3,NaN,4,5,6,NaN] contains 2 NaNs at the index of (3,7) assert_true:
expected true got false
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS [object Promise] rejected correctly with "TypeError: Failed to execute
'decodeAudioData' on 'AudioContext': 1 argument required, but only 0 present.".
PASS Start OAC rendering resolved correctly.
FAIL << [basic] 1 out of 18 assertions were failed. assert_true: expected true
got false
PASS >> [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
<0:1> <1:8> <2:11> <3:18> <4:6> and 2 more errors. assert_true: expected true
got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]: <2:11 != 10> <6:5 != 6> <9:49 != 48> assert_true:
expected true got false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: [1,2,3].
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
PASS [0.11,0.19] equals [0.1,0.2] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
FAIL << [numerical] 4 out of 10 assertions were failed. assert_true: expected
true got false
FAIL ## AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
At index [0]: got 1.
At index [1]: got 8.
At index [2]: got 11.
At index [3]: got 18.
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
At index [2] got 11 expected 10.
At index [6] got 5 expected 6.
At index [9] got 49 expected 48. assert_true: expected true got false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
PTAL. Many parts were replaced/removed for the clean up and refactoring. Also updated the printed output in the CL description accordingly. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:31: // TODO(hongchan): is this something we want? On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > Do we really need this? I think we should let testharness and the browser do > > what ever it wants. > > For my use case, this significantly improves the readability of the test result. I decided to remove this. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:75: // or Float32Array). Returns a result with indices of NaN. On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > Update comment because it returns for an indices. (Is that a Javascript object > > type? Maybe you want to say it's an array.) > > This method is confusing. I thought it's clever to detect a NaN or NaNs in an > array, but both the result and the intention are confusing. (Just like you > misread the name...) This method is removed. It's better to use isNaN() or Array.includes(NaN). https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:85: } else if (target instanceof Float32Array || target instanceof Array) { On 2016/11/08 21:14:18, Raymond Toy wrote: > Should we support Float64Array too? The method is removed. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:111: // TODO(hongchan): this might not be needed. On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > You're using this, so it's needed right? > > This needs more work. There are some stuffs that can be salvaged. I scaled down to a single case (object/array), but we can expand if needed in the future. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:130: // } else { On 2016/11/08 22:07:28, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > This should be removed. > > I am still deciding on this. We need some method to assemble a string out of > array or object. Removed. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:135: // let elements = targetString.split(' '); On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > This should be removed. > > Noted. I will sit on this few more days. Removed. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:157: * with a assertion subtask. On 2016/11/08 21:14:18, Raymond Toy wrote: > "a assertion" -> "an assertion" > > Not really clear what an "assertion subtask" means here. This class is removed. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:291: didThrow = false; On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > Why false? This did throw, right? If it didn't, then failDetail below is > also > > wrong. > > I should rename the variable to |passed|. The third else clause handles the > case where it throws but with a wrong error type. Done with a different variable name. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:629: * Check if |actual| array contains a set of |expected| values in a certain On 2016/11/14 17:44:34, Raymond Toy wrote: > On 2016/11/08 22:07:29, hongchan wrote: > > On 2016/11/08 21:14:18, Raymond Toy wrote: > > > Need to expand on this to explain what "certain order" really means. > > > > Perhaps a 'user-defined' order? > > Yes, that's much clearer. Or just say the array contains only the values in > |expected| in the order of values in |expected|. Done. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:658: * Check if |actual| array does not have any glitches. Note that |threshold| On 2016/11/14 17:44:34, Raymond Toy wrote: > On 2016/11/08 22:07:29, hongchan wrote: > > On 2016/11/08 21:14:18, Raymond Toy wrote: > > > Needs more detailed explanation of what "glitch" means. Didn't we have a > more > > > detailed comment from Audit? > > > > Nope. The comments are same. I didn't use the example though - because the > > syntax has been changed. > > > > 1) Examples in the comment. > > 2) Live examples in the unit test HTML. > > > > Which one do you prefer? > > Prefer 1 because it's easier to find; I won't be looking at the unit-test html > when trying to figure this out. > > If the example it too long, then reference the unit-test html, I guess. (Or > both). > > And maybe at the top of this file add a reference to the unit-test file. I > think this also means the unit-test file should exercise all possible options > for every single method here. > > Is there a way to mark a test as expected to fail? That would be really useful. > (I suspect testharness doesn't allow that.) Added examples. Your request on the last comment will be addressed in the next iteration. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/resources/audit.js:817: // Start running all the tasks scheduled. On 2016/11/08 22:07:29, hongchan wrote: > On 2016/11/08 21:14:18, Raymond Toy wrote: > > Probably want to describe the optional args to run() here. > > It's being properly handled. See the if statement below. Oh, I misunderstood your comment. Added comments about the optional arguments to describe the behavior.
lgtm with a few minor tweaks that we discussed offline. Can't wait to start using this!
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
At index [0]: got 1.
At index [1]: got 8.
At index [2]: got 11.
At index [3]: got 18.
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
At index [2] got 11 expected 10.
At index [6] got 5 expected 6.
At index [9] got 49 expected 48. assert_true: expected true got false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 5 out of 10 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 5 out of 10 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
Thanks for the review. I am expecting more feature request along with bug fixes in the future iteration.
The CQ bit was checked by hongchan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org Link to the patchset: https://codereview.chromium.org/2435593009/#ps120001 (title: "Fixing nits after l-g-t-m")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
[DO NOT SUBMIT]
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
Description was changed from
==========
Please try this out and review the CL in small chunks.
Here's the test result:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
The sample result from |audit.html| unit test:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by hongchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by hongchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by hongchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480491946943090,
"parent_rev": "a587a1f9d9c3245af62720382547b43b8ff2f016", "commit_rev":
"15b9809e008d9853568c792b9711c57b0f7eac3e"}
Message was sent while issue was closed.
Description was changed from
==========
The sample result from |audit.html| unit test:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
The sample result from |audit.html| unit test:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from
==========
The sample result from |audit.html| unit test:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
==========
to
==========
The sample result from |audit.html| unit test:
----
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic] Simple unit tests for basic assertions.
PASS OfflineAudioContext does exist.
PASS Setting foo to 0 did not throw an exception.
PASS function () { var foo = bar; } threw ReferenceError : "bar is not
defined".
PASS 3 < 5 is true.
PASS false is false.
PASS 1 is equal to 1.
PASS 1 is not equal to 2.
PASS object is equal to object.
PASS 2 is greater than 1.
PASS 2 is greater than or equal to 2.
PASS 1 is less than 2.
PASS 1 is less than or equal to 1.
PASS undefined rejected correctly with TypeError: Failed to execute
'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0
present..
PASS Start OAC rendering resolved correctly.
PASS < [basic] All assertion passed. (total 14 assertions)
PASS > [numerical] Numerical assertion unit test.
PASS 2.3 is 2 within an error of 0.3
PASS [1,1,1] contains only the constant 1.
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5:
Index Actual
[0] 1
[1] 8
[2] 11
[3] 18
...and 3 more errors. assert_true: expected true got false
PASS [1,1,1] is identical to the array [1,1,1].
FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to
[1,8,10,18,6,5,6,5,123,48]:
Index Actual Expected
[2] 1.1000000000000000e+1 1.0000000000000000e+1
[6] 5.0000000000000000e+0 6.0000000000000000e+0
[9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got
false
PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct
order: one, two, three.
FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6.
assert_true: expected true got false
PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06.
FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size
0.04999999999999999. assert_true: expected true got false
FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2
Max AbsError of 1.0999999999999999e-1 at index of 1.
Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true
got false
FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal
[0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of
{"absoluteThreshold":0.02,"relativeThreshold":0.1}.
Index Actual Expected AbsError RelError Test threshold
[0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2
[1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2
[2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2
[4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2
[5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2
Max AbsError of 5.9999999999999998e-1 at index of 0.
Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true
got false
FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected
true got false
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
----
BUG=663093
TEST= LayoutTests/webaudio/unit-tests/audit.html
Committed: https://crrev.com/c06bb6dbd09d88d8d2e8ecda9e9a016d9b3dfe40
Cr-Commit-Position: refs/heads/master@{#435150}
==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/c06bb6dbd09d88d8d2e8ecda9e9a016d9b3dfe40 Cr-Commit-Position: refs/heads/master@{#435150} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
