Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2435593009: New WebAudio layout testing utility: audit.js (Closed)

Created:
4 years, 2 months ago by hongchan
Modified:
4 years ago
Reviewers:
Raymond Toy
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The sample result from |audit.html| unit test: ---- This is a testharness.js-based test. PASS # AUDIT TASK RUNNER STARTED. PASS > [basic] Simple unit tests for basic assertions. PASS OfflineAudioContext does exist. PASS Setting foo to 0 did not throw an exception. PASS function () { var foo = bar; } threw ReferenceError : "bar is not defined". PASS 3 < 5 is true. PASS false is false. PASS 1 is equal to 1. PASS 1 is not equal to 2. PASS object is equal to object. PASS 2 is greater than 1. PASS 2 is greater than or equal to 2. PASS 1 is less than 2. PASS 1 is less than or equal to 1. PASS undefined rejected correctly with TypeError: Failed to execute 'decodeAudioData' on 'BaseAudioContext': 1 argument required, but only 0 present.. PASS Start OAC rendering resolved correctly. PASS < [basic] All assertion passed. (total 14 assertions) PASS > [numerical] Numerical assertion unit test. PASS 2.3 is 2 within an error of 0.3 PASS [1,1,1] contains only the constant 1. FAIL X [1,8,11,18,6,5,5,5,123,49] contains 7 values that are *NOT* equal to 5: Index Actual [0] 1 [1] 8 [2] 11 [3] 18 ...and 3 more errors. assert_true: expected true got false PASS [1,1,1] is identical to the array [1,1,1]. FAIL X [1,8,11,18,6,5,5,5,123,49] contains 3 values that are *NOT* equal to [1,8,10,18,6,5,6,5,123,48]: Index Actual Expected [2] 1.1000000000000000e+1 1.0000000000000000e+1 [6] 5.0000000000000000e+0 6.0000000000000000e+0 [9] 4.9000000000000000e+1 4.8000000000000000e+1 assert_true: expected true got false PASS [1,1,1,1,2,2,3,3,3] contains all the expected values in the correct order: one, two, three. FAIL X [1,1,1,1,2,2,3,3,3] contains an unexpected value of 3 at index 6. assert_true: expected true got false PASS [0.5,0.5,0.55,0.5,0.45,0.5] has no glitch above the threshold of 0.06. FAIL X [0.5,0.5,0.55,0.5,0.45,0.5] has a glitch at index 5 of size 0.04999999999999999. assert_true: expected true got false FAIL X [0.11,0.19] does not equal [0.1,0.3] with an element-wise tolerance of {"absoluteThreshold":0.02,"relativeThreshold":0.1}. Index Actual Expected AbsError RelError Test threshold [1] 1.9000000000000000e-1 2.9999999999999999e-1 1.0999999999999999e-1 3.6666666666666664e-1 2.9999999999999999e-2 Max AbsError of 1.0999999999999999e-1 at index of 1. Max RelError of 3.6666666666666664e-1 at index of 1. assert_true: expected true got false FAIL X [0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.9] does not equal [0.7,0.6,0.5,0.4,0.3,0.2,0.1] with an element-wise tolerance of {"absoluteThreshold":0.02,"relativeThreshold":0.1}. Index Actual Expected AbsError RelError Test threshold [0] 1.0000000000000001e-1 6.9999999999999996e-1 5.9999999999999998e-1 8.5714285714285721e-1 6.9999999999999993e-2 [1] 2.0000000000000001e-1 5.9999999999999998e-1 3.9999999999999997e-1 6.6666666666666663e-1 5.9999999999999998e-2 [2] 2.9999999999999999e-1 5.0000000000000000e-1 2.0000000000000001e-1 4.0000000000000002e-1 5.0000000000000003e-2 [4] 5.0000000000000000e-1 2.9999999999999999e-1 2.0000000000000001e-1 6.6666666666666674e-1 2.9999999999999999e-2 [5] 5.9999999999999998e-1 2.0000000000000001e-1 3.9999999999999997e-1 1.9999999999999998e+0 2.0000000000000004e-2 Max AbsError of 5.9999999999999998e-1 at index of 0. Max RelError of 5.9999999999999991e+0 at index of 6. assert_true: expected true got false FAIL < [numerical] 6 out of 11 assertions were failed. assert_true: expected true got false FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed. assert_true: expected true got false Harness: the test ran to completion. ---- BUG=663093 TEST= LayoutTests/webaudio/unit-tests/audit.html Committed: https://crrev.com/c06bb6dbd09d88d8d2e8ecda9e9a016d9b3dfe40 Cr-Commit-Position: refs/heads/master@{#435150}

Patch Set 1 #

Patch Set 2 : New WebAudio layout test utility: audit.js #

Patch Set 3 : Improving test outputs #

Patch Set 4 : more progress #

Total comments: 44

Patch Set 5 : Addressing feedback from rtoy@ #

Patch Set 6 : Ready for review #

Patch Set 7 : Fixing nits after l-g-t-m #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1061 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 2 3 4 5 6 1 chunk +980 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html View 1 2 3 4 5 6 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 39 (22 generated)
hongchan
PTAL. I think the patch reached the point where the preliminary review is possible. Early ...
4 years, 2 months ago (2016-10-20 22:37:02 UTC) #4
hongchan
On 2016/10/20 22:37:02, hongchan wrote: > PTAL. > > I think the patch reached the ...
4 years, 1 month ago (2016-11-07 22:43:23 UTC) #6
Raymond Toy
https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode24 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:24: if (!self.hasOwnProperty(testharnessProperties[name])) { From our BaseAudioContext experience, do we ...
4 years, 1 month ago (2016-11-08 21:14:19 UTC) #9
hongchan
Thanks for the review! I'll address the comments soon. https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode24 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:24: ...
4 years, 1 month ago (2016-11-08 22:07:29 UTC) #10
Raymond Toy
https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2435593009/diff/60001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode622 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:622: + 'element-wise tolerance of ' + maxAllowedErrorDetail + '.'; ...
4 years, 1 month ago (2016-11-14 17:44:34 UTC) #11
hongchan
PTAL. Many parts were replaced/removed for the clean up and refactoring. Also updated the printed ...
4 years ago (2016-11-29 20:25:01 UTC) #13
Raymond Toy
lgtm with a few minor tweaks that we discussed offline. Can't wait to start using ...
4 years ago (2016-11-29 21:30:47 UTC) #14
hongchan
Thanks for the review. I am expecting more feature request along with bug fixes in ...
4 years ago (2016-11-29 21:41:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435593009/120001
4 years ago (2016-11-29 21:42:50 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on ...
4 years ago (2016-11-29 23:46:20 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435593009/120001
4 years ago (2016-11-29 23:50:27 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-30 00:10:44 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435593009/120001
4 years ago (2016-11-30 02:41:17 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-30 04:42:36 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435593009/120001
4 years ago (2016-11-30 07:46:51 UTC) #34
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years ago (2016-11-30 08:00:55 UTC) #37
commit-bot: I haz the power
4 years ago (2016-11-30 08:05:18 UTC) #39
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c06bb6dbd09d88d8d2e8ecda9e9a016d9b3dfe40
Cr-Commit-Position: refs/heads/master@{#435150}

Powered by Google App Engine
This is Rietveld 408576698