Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 24355002: Overhaul tracing_ui to use XHR and new tracing_controller (Closed)

Created:
7 years, 2 months ago by nduca
Modified:
7 years, 1 month ago
Reviewers:
haraken, Xianzhu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam
Visibility:
Public.

Description

Overhaul tracing_ui to use XHR and new tracing_controller Pairs with https://codereview.appspot.com/13831043

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : Producing empty trace files #

Patch Set 4 : make it work #

Total comments: 1

Patch Set 5 : Rebase #

Patch Set 6 : TracingController::GetTraceBufferPercentFull() #

Patch Set 7 : #

Patch Set 8 : Rebase; Process options #

Patch Set 9 : Fix wrong usages of RefCountedString::TakeString #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -523 lines) Patch
M content/browser/tracing/trace_message_filter.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 1 2 3 4 5 6 7 3 chunks +16 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 2 3 4 5 6 7 4 chunks +68 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 2 3 4 5 6 7 8 2 chunks +101 lines, -521 lines 0 comments Download
M content/public/browser/tracing_controller.h View 1 2 3 4 5 6 7 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haraken
https://codereview.chromium.org/24355002/diff/6001/content/browser/tracing/trace_message_filter.cc File content/browser/tracing/trace_message_filter.cc (right): https://codereview.chromium.org/24355002/diff/6001/content/browser/tracing/trace_message_filter.cc#newcode93 content/browser/tracing/trace_message_filter.cc:93: TracingControllerImpl::GetInstance()->AddFilter(this); Some tracing APIs are still using TraceControllerImpl, so ...
7 years, 2 months ago (2013-10-02 03:31:43 UTC) #1
Xianzhu
PTAL - Keep both TraceControllerImpl (temporary) and TracingControllerImpl callbacks; - Added TraceController::GetTraceBufferPercentFull().
7 years, 1 month ago (2013-11-14 01:44:19 UTC) #2
nduca
lgtm when you're ready
7 years, 1 month ago (2013-11-15 02:17:43 UTC) #3
nduca
7 years, 1 month ago (2013-11-15 02:18:09 UTC) #4
oh hmm you might need to re-up this patch as you so that i can lg it haha

Powered by Google App Engine
This is Rietveld 408576698