Add media remoting unittests to media_unittests.

Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
NOTRY=true

Committed: https://crrev.com/9da998021d11a994b5c30d7f6f6b2f3b2bf8a8db
Cr-Commit-Position: refs/heads/master@{#427562}

[xjz, 2016-10-21 20:54:03]

Description was changed from

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
==========

to

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
==========

[xjz, 2016-10-21 20:54:03]

xjz@chromium.org changed reviewers:
+ jam@chromium.org, miu@chromium.org, xhwang@chromium.org

[xjz, 2016-10-21 20:54:47]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 20:55:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 21:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:17:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xjz, 2016-10-21 21:32:04]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 21:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xjz, 2016-10-21 22:47:48]

Patchset #1 (id:1) has been deleted

[xjz, 2016-10-21 22:54:04]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:54:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xjz, 2016-10-21 23:03:44]

Patchset #1 (id:20001) has been deleted

[xjz, 2016-10-21 23:44:15]

jam@: PTAL.

miu@, xhwang@: FYI.

[xhwang, 2016-10-22 00:02:33]

lgtm % one question

https://codereview.chromium.org/2435423002/diff/30001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/2435423002/diff/30001/media/BUILD.gn#newcode732
media/BUILD.gn:732: deps += [ "//media/remoting:media_remoting_unittests" ]
Does the tests work if enable_media_remoting is false? If so, we should always
enable the tests.

[miu, 2016-10-22 00:16:48]

https://codereview.chromium.org/2435423002/diff/30001/media/remoting/BUILD.gn
File media/remoting/BUILD.gn (right):

https://codereview.chromium.org/2435423002/diff/30001/media/remoting/BUILD.gn...
media/remoting/BUILD.gn:46: source_set("media_remoting_unittests") {
Please see the initial plan in https://crbug.com/656112.

I think xhwang's idea was to name this source_set "media_remoting_tests" and
then have it included in *two* separate test binaries: media_unittests and
media_remoting_unittests. The latter would only be used to build/run on our
local desktops when we just want to test media remoting stuff.

So, I think all you need to do is rename this source set to
"media_remoting_tests" and create another test target in this file:

  test("media_remoting_unittests") {
    deps = [ ":media_remoting_tests",
             "//media/test:run_all_unittests", ]
  }

[xjz, 2016-10-22 00:44:33]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 00:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xjz, 2016-10-22 00:47:44]

Addressed comments. PTAL

https://codereview.chromium.org/2435423002/diff/30001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/2435423002/diff/30001/media/BUILD.gn#newcode732
media/BUILD.gn:732: deps += [ "//media/remoting:media_remoting_unittests" ]
On 2016/10/22 00:02:33, xhwang wrote:
> Does the tests work if enable_media_remoting is false? If so, we should always
> enable the tests.

After discussing with miu@ offline, we decide to run these tests only when
enable_media_remoting is true, i.e., on Linux, Windows, and Mac only, because
the Media Remoting feature is only enabled on these platforms for now.

https://codereview.chromium.org/2435423002/diff/30001/media/remoting/BUILD.gn
File media/remoting/BUILD.gn (right):

https://codereview.chromium.org/2435423002/diff/30001/media/remoting/BUILD.gn...
media/remoting/BUILD.gn:46: source_set("media_remoting_unittests") {
On 2016/10/22 00:16:48, miu wrote:
> Please see the initial plan in https://crbug.com/656112.
> 
> I think xhwang's idea was to name this source_set "media_remoting_tests" and
> then have it included in *two* separate test binaries: media_unittests and
> media_remoting_unittests. The latter would only be used to build/run on our
> local desktops when we just want to test media remoting stuff.
> 
> So, I think all you need to do is rename this source set to
> "media_remoting_tests" and create another test target in this file:
> 
>   test("media_remoting_unittests") {
>     deps = [ ":media_remoting_tests",
>              "//media/test:run_all_unittests", ]
>   }

Done.

[miu, 2016-10-22 01:00:54]

lgtm

[commit-bot: I haz the power, 2016-10-22 02:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 02:26:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xjz, 2016-10-24 20:44:27]

jam@: LGTY?

[jam, 2016-10-25 00:18:38]

lgtm, thanks

[xjz, 2016-10-25 16:08:54]

The CQ bit was checked by xjz@chromium.org

[xjz, 2016-10-25 16:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2435423002/#ps50001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-10-25 16:09:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:33:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xjz, 2016-10-25 18:40:24]

The CQ bit was checked by xjz@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 20:51:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:51:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xjz, 2016-10-25 22:16:57]

The CQ bit was checked by xjz@chromium.org

[commit-bot: I haz the power, 2016-10-25 22:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 00:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 00:44:45]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xjz, 2016-10-26 01:10:20]

Description was changed from

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
==========

to

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
NOTRY=true
==========

[xjz, 2016-10-26 01:14:20]

Set NOTRY=true because linux_chromium_rel_ng keeps failing on tests that are
unrelated to this CL.

[xjz, 2016-10-26 01:14:26]

The CQ bit was checked by xjz@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:22:33]

Description was changed from

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
NOTRY=true
==========

to

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
NOTRY=true
==========

[commit-bot: I haz the power, 2016-10-26 01:22:34]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2016-10-26 01:26:32]

Description was changed from

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
NOTRY=true
==========

to

==========
Add media remoting unittests to media_unittests.
Remove media_remoting_unittests from the FYI bots. Instead, add them
to media_unittests as a subset of the tests.

BUG=643964
NOTRY=true

Committed: https://crrev.com/9da998021d11a994b5c30d7f6f6b2f3b2bf8a8db
Cr-Commit-Position: refs/heads/master@{#427562}
==========

[commit-bot: I haz the power, 2016-10-26 01:26:33]

Patchset 2 (id:??) landed as
https://crrev.com/9da998021d11a994b5c30d7f6f6b2f3b2bf8a8db
Cr-Commit-Position: refs/heads/master@{#427562}